Source/core/dom/Document.h - Issue 252713004: Make default for deep parameter in importNode false

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.h

Issue 252713004: Make default for deep parameter in importNode false (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add warning message Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.h

diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h

index 11136c74adb787c36dd3c1b5ce1ef8c676fc810a..01a1f635b9d33dbb5b116aa82cf122fc5c45bcd9 100644

--- a/Source/core/dom/Document.h

+++ b/Source/core/dom/Document.h

@@ -323,7 +323,7 @@ public:

PassRefPtr<ProcessingInstruction> createProcessingInstruction(const String& target, const String& data, ExceptionState&);

PassRefPtr<Attr> createAttribute(const AtomicString& name, ExceptionState&);

PassRefPtr<Attr> createAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&, bool shouldIgnoreNamespaceChecks = false);

- PassRefPtr<Node> importNode(Node* importedNode, ExceptionState& ec) { return importNode(importedNode, true, ec); }

+ PassRefPtr<Node> importNode(Node* importedNode, ExceptionState&);

PassRefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionState&);

PassRefPtr<Element> createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);

PassRefPtr<Element> createElement(const QualifiedName&, bool createdByParser);

« no previous file with comments | « LayoutTests/fast/html/imports/resources/custom-element-style.html ('k') | Source/core/dom/Document.cpp » ('j') | Source/core/dom/Document.cpp » ('J')