Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: Source/core/dom/Document.h

Issue 252713004: Make default for deep parameter in importNode false (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/html/imports/resources/custom-element-style.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 40c837de1e9afd6e835a0cd728bb3edecba8ba87..855fdae88dc0dec9bb181da0809399297940bff5 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -323,7 +323,7 @@ public:
PassRefPtr<ProcessingInstruction> createProcessingInstruction(const String& target, const String& data, ExceptionState&);
PassRefPtr<Attr> createAttribute(const AtomicString& name, ExceptionState&);
PassRefPtr<Attr> createAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&, bool shouldIgnoreNamespaceChecks = false);
- PassRefPtr<Node> importNode(Node* importedNode, ExceptionState& ec) { return importNode(importedNode, true, ec); }
+ PassRefPtr<Node> importNode(Node* importedNode, ExceptionState& ec) { return importNode(importedNode, false, ec); }
Inactive 2014/04/27 19:33:56 We likely don't need this method overload at all i
PassRefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionState&);
PassRefPtr<Element> createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);
PassRefPtr<Element> createElement(const QualifiedName&, bool createdByParser);
« no previous file with comments | « LayoutTests/fast/html/imports/resources/custom-element-style.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698