Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 252713004: Make default for deep parameter in importNode false (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase against ToT Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 897 matching lines...) Expand 10 before | Expand all | Expand 10 after
908 if (exceptionState.hadException()) 908 if (exceptionState.hadException())
909 return false; 909 return false;
910 newContainerNode->appendChild(newChild.release(), exceptionState); 910 newContainerNode->appendChild(newChild.release(), exceptionState);
911 if (exceptionState.hadException()) 911 if (exceptionState.hadException())
912 return false; 912 return false;
913 } 913 }
914 914
915 return true; 915 return true;
916 } 916 }
917 917
918 PassRefPtr<Node> Document::importNode(Node* importedNode, ExceptionState& ec)
919 {
920 UseCounter::countDeprecation(this, UseCounter::DocumentImportNodeOptionalArg ument);
921 return importNode(importedNode, true, ec);
922 }
923
918 PassRefPtr<Node> Document::importNode(Node* importedNode, bool deep, ExceptionSt ate& exceptionState) 924 PassRefPtr<Node> Document::importNode(Node* importedNode, bool deep, ExceptionSt ate& exceptionState)
919 { 925 {
920 if (!importedNode) { 926 if (!importedNode) {
921 exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::a rgumentNullOrIncorrectType(1, "Node")); 927 exceptionState.throwDOMException(NotSupportedError, ExceptionMessages::a rgumentNullOrIncorrectType(1, "Node"));
922 return nullptr; 928 return nullptr;
923 } 929 }
924 930
925 switch (importedNode->nodeType()) { 931 switch (importedNode->nodeType()) {
926 case TEXT_NODE: 932 case TEXT_NODE:
927 return createTextNode(importedNode->nodeValue()); 933 return createTextNode(importedNode->nodeValue());
(...skipping 4738 matching lines...) Expand 10 before | Expand all | Expand 10 after
5666 visitor->trace(m_mediaQueryMatcher); 5672 visitor->trace(m_mediaQueryMatcher);
5667 visitor->trace(m_visibilityObservers); 5673 visitor->trace(m_visibilityObservers);
5668 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this); 5674 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
5669 DocumentSupplementable::trace(visitor); 5675 DocumentSupplementable::trace(visitor);
5670 TreeScope::trace(visitor); 5676 TreeScope::trace(visitor);
5671 ContainerNode::trace(visitor); 5677 ContainerNode::trace(visitor);
5672 ExecutionContext::trace(visitor); 5678 ExecutionContext::trace(visitor);
5673 } 5679 }
5674 5680
5675 } // namespace WebCore 5681 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698