Issue 252713003: Revert 265881 - "Add simple PRESUBMIT check to ensure that all files ending with .json can"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252713003: Revert 265881 - "Add simple PRESUBMIT check to ensure that all files ending with .json can" (Closed)

Created:
6 years, 8 months ago by Yoyo Zhou

Modified:
6 years, 8 months ago

Reviewers:
Thiemo Nagel, iannucci, jochen (gone - plz use gerrit), M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert 265881 - "Add simple PRESUBMIT check to ensure that all files ending with .json can" Revert 266019 - "Add detail to 'invalid JSON' message in PRESUBMIT.py." This presubmit check is invalid - it fails on existing .json files in the tree that contain comments. (Other JSON-reading tools strip out these comments.) Any changes to these .json files are incorrectly rejected by this check. BUG=366395 TBR=iannucci@chromium.org,tnagel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266191

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -16 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

6 years, 8 months ago (2014-04-25 15:15:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r266191 (presubmit successful).

Expand Messages | Collapse Messages