Issue 252713002: Create SkGlyphCache globals with SkOnce.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252713002: Create SkGlyphCache globals with SkOnce. (Closed)

Created:
6 years, 8 months ago by bungeman-skia

Modified:
6 years, 7 months ago

Reviewers:
epoger, mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Create SkGlyphCache globals with SkOnce. VC++ will have magic statics with VS2014, but does not currently have them. The thread unsafe implementation was causing the DirectWrite bots to randomly crash when running multi-threaded tests, as gGlobals could be seen as NULL. R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=14397

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	src/core/SkGlyphCache.cpp	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bungeman-chromium

Committed patchset #1 manually as r14397 (presubmit successful).

6 years, 7 months ago (2014-04-28 13:58:37 UTC) #3

epoger

6 years, 7 months ago (2014-04-28 14:54:15 UTC) #4

Message was sent while issue was closed.

Please use the commit-queue, when possible, to increase chances of catching
compile errors.

Expand Messages | Collapse Messages