Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

No File IO (default):
  The task does not perform synchronous IO operations.
  It spends most of its time using the CPU.

With Wait:
  The task waits on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191
Committed: https://crrev.com/30824582b818b41f8b264eae2658a2878a7d9939
Cr-Commit-Position: refs/heads/master@{#435948}

[fdoray, 2016-11-24 20:07:23]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 20:07:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 20:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 20:33:57]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[fdoray, 2016-12-01 20:01:56]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 20:02:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-01 20:02:50]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

No File IO (default):
  The task does not perform synchronous IO operations.
  It spends most of its time using the CPU.

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

No File IO (default):
  The task does not perform synchronous IO operations.
  It spends most of its time using the CPU.

With Wait:
  The task waits on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191
==========

[commit-bot: I haz the power, 2016-12-01 20:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 20:54:26]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-12-01 21:01:11]

fdoray@chromium.org changed reviewers:
+ vabr@chromium.org

[fdoray, 2016-12-01 21:01:12]

Please review this CL. You should verify that the traits mentioned in the CL
description make sense for this task. Thanks!

Note: WorkerPool is being deprecated in favor of TaskScheduler. Read the design
doc
https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa...

Note: On shutdown, WorkerPool does not wait for tasks to run. To get the same
behavior in TaskScheduler, we used TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN.

[vabr (Chromium), 2016-12-02 15:06:28]

Thanks, LGTM.

The traits look correct. I'm not completely sure about "with wait", but the task
calls some Windows API, so perhaps that's a reason to have that?

I also acknowledge that removing the UMA histogram here makes sense.

Cheers,
Vaclav

[fdoray, 2016-12-02 16:24:52]

On 2016/12/02 15:06:28, vabr (Chromium) wrote:
> Thanks, LGTM.
> 
> The traits look correct. I'm not completely sure about "with wait", but the
task
> calls some Windows API, so perhaps that's a reason to have that?
> 
> I also acknowledge that removing the UMA histogram here makes sense.
> 
> Cheers,
> Vaclav

There is a WithWait() because of the blocking Windows API call (LogonUser).

[fdoray, 2016-12-02 16:24:58]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-12-02 16:25:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 16:29:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480695898523740,
"parent_rev": "391fb9a54bdfb03591c737e02e017e53b5ec0b49", "commit_rev":
"18147a6ec5855a75b5e0451de0a51690fc2ffb14"}

[commit-bot: I haz the power, 2016-12-02 16:30:04]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

No File IO (default):
  The task does not perform synchronous IO operations.
  It spends most of its time using the CPU.

With Wait:
  The task waits on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

No File IO (default):
  The task does not perform synchronous IO operations.
  It spends most of its time using the CPU.

With Wait:
  The task waits on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191
==========

[commit-bot: I haz the power, 2016-12-02 16:30:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 16:31:57]

Description was changed from

==========
Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

No File IO (default):
  The task does not perform synchronous IO operations.
  It spends most of its time using the CPU.

With Wait:
  The task waits on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191
==========

to

==========
Use TaskScheduler instead of WorkerPool in password_manager_util_win.cc.

This CL replaces base::WorkerPool::PostTask() with
base::PostTaskWithTraits() call. The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

No File IO (default):
  The task does not perform synchronous IO operations.
  It spends most of its time using the CPU.

With Wait:
  The task waits on things other than synchronous file IO
  operations (e.g. WaitableEvent, ConditionVariable, join a thread,
  join a process, blocking system call that doesn't involve
  interactions with the file system).

BUG=659191

Committed: https://crrev.com/30824582b818b41f8b264eae2658a2878a7d9939
Cr-Commit-Position: refs/heads/master@{#435948}
==========

[commit-bot: I haz the power, 2016-12-02 16:31:58]

Patchset 2 (id:??) landed as
https://crrev.com/30824582b818b41f8b264eae2658a2878a7d9939
Cr-Commit-Position: refs/heads/master@{#435948}