[iOS] Upstream web_controller_provider_impl.{h,mm}.

[iOS] Upstream web_controller_provider_impl.{h,mm}.

Upstream the implementation of WebControllerProviderImpl, split the
file to move the factory and the class in separate files. Fix deps.

Dependency on the upstream class can be added in that CL as it is in
a different namespace as the downstream implementation and do not
conflict.

BUG=None

Committed: https://crrev.com/21a52db5fec1a61393b2aedbe5bf0b834d9d97eb
Cr-Commit-Position: refs/heads/master@{#434485}

[sdefresne, 2016-11-24 15:37:25]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2016-11-24 15:37:25]

Please take a look.

[sdefresne, 2016-11-24 15:39:21]

Patchset #1 (id:1) has been deleted

[sdefresne, 2016-11-25 10:26:28]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 10:26:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 11:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 11:18:06]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-11-25 12:11:33]

lgtm

https://codereview.chromium.org/2527123003/diff/40001/ios/chrome/browser/web/...
File ios/chrome/browser/web/web_controller_provider_impl.h (right):

https://codereview.chromium.org/2527123003/diff/40001/ios/chrome/browser/web/...
ios/chrome/browser/web/web_controller_provider_impl.h:5: #ifndef
IOS_INTERNAL_CHROME_BROWSER_WEB_WEB_CONTROLLER_PROVIDER_IMPL_H_
IOS_CHROME_etc

https://codereview.chromium.org/2527123003/diff/40001/ios/web/DEPS
File ios/web/DEPS (left):

https://codereview.chromium.org/2527123003/diff/40001/ios/web/DEPS#oldcode4
ios/web/DEPS:4: "+ios/public/provider/web",
Was this rule no longer necessary?  I don't see any changes to files in ios/web
in this CL.

[sdefresne, 2016-11-25 12:22:49]

On 2016/11/25 12:11:33, rohitrao wrote:
> lgtm
> 
>
https://codereview.chromium.org/2527123003/diff/40001/ios/chrome/browser/web/...
> File ios/chrome/browser/web/web_controller_provider_impl.h (right):
> 
>
https://codereview.chromium.org/2527123003/diff/40001/ios/chrome/browser/web/...
> ios/chrome/browser/web/web_controller_provider_impl.h:5: #ifndef
> IOS_INTERNAL_CHROME_BROWSER_WEB_WEB_CONTROLLER_PROVIDER_IMPL_H_
> IOS_CHROME_etc
> 
> https://codereview.chromium.org/2527123003/diff/40001/ios/web/DEPS
> File ios/web/DEPS (left):
> 
> https://codereview.chromium.org/2527123003/diff/40001/ios/web/DEPS#oldcode4
> ios/web/DEPS:4: "+ios/public/provider/web",
> Was this rule no longer necessary?  I don't see any changes to files in
ios/web
> in this CL.

Yes there were many unnecessary dependencies.

[sdefresne, 2016-11-25 12:22:53]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-11-25 12:23:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 12:26:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480076573919400,
"parent_rev": "658bb96b6cb311263b28c097df6fca5bb35924e9", "commit_rev":
"44434972e3790f0b4c2bc4f4f2d747bdc8fef64b"}

[commit-bot: I haz the power, 2016-11-25 12:27:11]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-25 12:29:57]

Description was changed from

==========
[iOS] Upstream web_controller_provider_impl.{h,mm}.

Upstream the implementation of WebControllerProviderImpl, split the
file to move the factory and the class in separate files. Fix deps.

Dependency on the upstream class can be added in that CL as it is in
a different namespace as the downstream implementation and do not
conflict.

BUG=None
==========

to

==========
[iOS] Upstream web_controller_provider_impl.{h,mm}.

Upstream the implementation of WebControllerProviderImpl, split the
file to move the factory and the class in separate files. Fix deps.

Dependency on the upstream class can be added in that CL as it is in
a different namespace as the downstream implementation and do not
conflict.

BUG=None

Committed: https://crrev.com/21a52db5fec1a61393b2aedbe5bf0b834d9d97eb
Cr-Commit-Position: refs/heads/master@{#434485}
==========

[commit-bot: I haz the power, 2016-11-25 12:29:58]

Patchset 2 (id:??) landed as
https://crrev.com/21a52db5fec1a61393b2aedbe5bf0b834d9d97eb
Cr-Commit-Position: refs/heads/master@{#434485}