Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2527083002: [turbofan] Use bounds checks to eliminate subsequent inc/dec overflow checks. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use bounds checks to eliminate subsequent inc/dec overflow checks. This has two parts: - in redundancy elimination, if we see addition with left hand side that was bounds-checked, we reconnect the lhs to the bounds check if it has better type. - in representation inference, eliminate overflow checks if the input types guarantee no overflow. Committed: https://crrev.com/cd0c259260d1b314e9983972114612f34f37274b Cr-Commit-Position: refs/heads/master@{#41260}

Patch Set 1 #

Patch Set 2 : Remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -25 lines) Patch
M src/compiler/redundancy-elimination.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/redundancy-elimination.cc View 3 chunks +47 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 3 chunks +53 lines, -25 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Jarin
Could you take a look, please? This helps Octane/crypto a bit by eliminating couple of ...
4 years ago (2016-11-24 10:56:59 UTC) #12
Benedikt Meurer
As per offline discussion, I'd do this for both inputs, and maybe apply the simplified ...
4 years ago (2016-11-24 12:30:46 UTC) #13
Benedikt Meurer
Otherwise LGTM.
4 years ago (2016-11-24 12:30:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527083002/20001
4 years ago (2016-11-24 12:56:32 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-24 12:58:08 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-24 12:58:30 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd0c259260d1b314e9983972114612f34f37274b
Cr-Commit-Position: refs/heads/master@{#41260}

Powered by Google App Engine
This is Rietveld 408576698