Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2527053002: [turbofan] Remove inlining support for the deprecated pipeline. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove inlining support for the deprecated pipeline. The deprecated pipeline is used for asm.js only, where we forcibly disable inlining anyways (for performance reasons), so inlining via the AstGraphBuilder is essentially dead code by now, thus there's no point in trying to keep that around in the code base. Also nuke the test-run-inlining.cc file, which would require some heavy surgery (for probably little benefit), and move the useful tests for mjsunit tests instead. BUG=v8:2206, v8:5657 R=yangguo@chromium.org Committed: https://crrev.com/76fd6f25a9ad4e02fe28beff97f8f083f1d48880 Cr-Commit-Position: refs/heads/master@{#41245}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -518 lines) Patch
M src/compiler/js-inlining.cc View 7 chunks +12 lines, -42 lines 0 comments Download
M src/compiler/pipeline.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/compiler/test-run-inlining.cc View 1 chunk +0 lines, -471 lines 0 comments Download
A test/mjsunit/compiler/capture-context.js View 1 chunk +16 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-context-deopt.js View 1 chunk +18 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-omit-arguments.js View 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-omit-arguments-deopt.js View 1 chunk +19 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-omit-arguments-object.js View 1 chunk +14 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-surplus-arguments.js View 1 chunk +12 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-surplus-arguments-deopt.js View 1 chunk +20 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/inline-surplus-arguments-object.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Benedikt Meurer
4 years ago (2016-11-24 07:02:23 UTC) #1
Yang
On 2016/11/24 07:02:23, Benedikt Meurer wrote: lgtm
4 years ago (2016-11-24 07:30:42 UTC) #6
Yang
https://codereview.chromium.org/2527053002/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/2527053002/diff/1/src/compiler/pipeline.cc#newcode565 src/compiler/pipeline.cc:565: if (FLAG_turbo_inlining) { just make this an 'else if'?
4 years ago (2016-11-24 07:30:49 UTC) #7
Benedikt Meurer
https://codereview.chromium.org/2527053002/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/2527053002/diff/1/src/compiler/pipeline.cc#newcode565 src/compiler/pipeline.cc:565: if (FLAG_turbo_inlining) { On 2016/11/24 07:30:49, Yang wrote: > ...
4 years ago (2016-11-24 07:34:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527053002/20001
4 years ago (2016-11-24 07:34:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-24 07:59:33 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-24 08:00:04 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76fd6f25a9ad4e02fe28beff97f8f083f1d48880
Cr-Commit-Position: refs/heads/master@{#41245}

Powered by Google App Engine
This is Rietveld 408576698