Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2527043002: Blink Animation: Request serviceOnNextFrame on animation's finish and cancel. (Closed)

Created:
4 years ago by loyso (OOO)
Modified:
4 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink Animation: Request serviceOnNextFrame on animation's finish and cancel. void AnimationTimeline::setOutdatedAnimation(Animation* animation) { DCHECK(animation->outdated()); m_outdatedAnimationCount++; m_animationsNeedingUpdate.add(animation); if (isActive() && !m_document->page()->animator().isServicingAnimations()) m_timing->serviceOnNextFrame(); } AnimationTimeline::setOutdatedAnimation doesn't request m_timing->serviceOnNextFrame() if animator().isServicingAnimations() (i.e. it is inside the requestAnimationFrame). Request it explicitly. BUG=620160 Committed: https://crrev.com/e796f22278e322c1b162deb5b6bbe1895b444c2e Cr-Commit-Position: refs/heads/master@{#434614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-in-raf.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/web-animations-api/animation-finish-in-raf.html View 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/Animation.cpp View 4 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
loyso (OOO)
4 years ago (2016-11-24 05:56:46 UTC) #6
loyso (OOO)
PTAL!
4 years ago (2016-11-28 06:31:18 UTC) #9
alancutter (OOO until 2018)
lgtm
4 years ago (2016-11-28 06:46:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527043002/1
4 years ago (2016-11-28 06:50:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 08:06:23 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-28 08:08:12 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e796f22278e322c1b162deb5b6bbe1895b444c2e
Cr-Commit-Position: refs/heads/master@{#434614}

Powered by Google App Engine
This is Rietveld 408576698