Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Issue 252703003: Wrote a test which exercises audio-only WebRTC calls. (Closed)

Created:
6 years, 8 months ago by phoglund_chromium
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Wrote a test which exercises audio-only WebRTC calls. Depends on https://codereview.chromium.org/260073013/ since it requires audio beeps generated even when the fake video device hasn't been acquired. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275790

Patch Set 1 #

Patch Set 2 : Made fixes to audio detection #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -54 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 2 4 chunks +34 lines, -41 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 2 3 chunks +7 lines, -8 lines 0 comments Download
M content/test/data/media/webrtc_test_audio.js View 1 2 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
phoglund_chromium
Nice Shijing, your patch made the test run perfectly! Please review this one after you ...
6 years, 7 months ago (2014-04-29 15:58:19 UTC) #1
no longer working on chromium
lgtm with one nit. https://codereview.chromium.org/252703003/diff/20001/content/test/data/media/webrtc_test_audio.js File content/test/data/media/webrtc_test_audio.js (right): https://codereview.chromium.org/252703003/diff/20001/content/test/data/media/webrtc_test_audio.js#newcode21 content/test/data/media/webrtc_test_audio.js:21: return; // The call probably ...
6 years, 6 months ago (2014-06-05 09:12:32 UTC) #2
phoglund_chromium
https://codereview.chromium.org/252703003/diff/20001/content/test/data/media/webrtc_test_audio.js File content/test/data/media/webrtc_test_audio.js (right): https://codereview.chromium.org/252703003/diff/20001/content/test/data/media/webrtc_test_audio.js#newcode21 content/test/data/media/webrtc_test_audio.js:21: return; // The call probably isn't up yet. On ...
6 years, 6 months ago (2014-06-09 06:55:36 UTC) #3
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 6 months ago (2014-06-09 06:55:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/252703003/40001
6 years, 6 months ago (2014-06-09 06:55:56 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 11:20:27 UTC) #6
Message was sent while issue was closed.
Change committed as 275790

Powered by Google App Engine
This is Rietveld 408576698