Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2527003002: [DONT COMMIT] Revert of Mus: ws/ should not depend on surfaces/ (Closed)

Created:
4 years ago by nhiroki
Modified:
4 years ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mus: ws/ should not depend on surfaces/ (patchset #2 id:20001 of https://codereview.chromium.org/2521123004/ ) Reason for revert: Speculative revert for issue 668105. This seems to be failing WindowServerTest.* and WindowTreeClientTest (mus_ws_unittests) on Ubuntu-12.04 and Windows-7-SP1. Original issue's description: > Mus: ws/ should not depend on surfaces/ > > As part of the mus-ws/mus-gpu split, the ws/ directory should not depend on > anything in surfaces/. > > BUG=none > > Committed: https://crrev.com/66f5a3fc0ebcf1fc89665685444eda4c1855eae2 > Cr-Commit-Position: refs/heads/master@{#434095} TBR=sky@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=668105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M services/ui/ws/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/ws/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/cursor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/display_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/platform_display_init_params.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/test_server_window_delegate.h View 2 chunks +2 lines, -6 lines 0 comments Download
M services/ui/ws/test_server_window_delegate.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M services/ui/ws/user_display_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_manager_state_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_server.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nhiroki
Created Revert of Mus: ws/ should not depend on surfaces/
4 years ago (2016-11-24 03:18:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2527003002/1
4 years ago (2016-11-24 03:19:48 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/312090) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-11-24 03:22:46 UTC) #6
nhiroki
4 years ago (2016-11-24 05:04:37 UTC) #7
Message was sent while issue was closed.
I closed this CL because fsamuel@ is now landing a fix:
https://codereview.chromium.org/2525213002/

Powered by Google App Engine
This is Rietveld 408576698