Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25270004: Fix bugs wrt to the content edge for v1 apps and panels (Closed)

Created:
7 years, 2 months ago by pkotwicz
Modified:
7 years, 2 months ago
Reviewers:
flackr, James Cook
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

This CL: - Makes the content edge visible for restored v1 apps - Makes the PanelFrameView header height the same as that for CustomFrameViewAsh BUG=301865 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226407

Patch Set 1 #

Total comments: 3

Patch Set 2 : Nits as per flackr@ #

Total comments: 1

Patch Set 3 : Nit as per jamescook@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M ash/wm/panels/panel_frame_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 1 2 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pkotwicz
flackr@, can you please take a look at the changes in ash/wm/panels
7 years, 2 months ago (2013-09-30 19:08:44 UTC) #1
flackr
LGTM with nits. https://codereview.chromium.org/25270004/diff/1/ash/wm/panels/panel_frame_view.cc File ash/wm/panels/panel_frame_view.cc (right): https://codereview.chromium.org/25270004/diff/1/ash/wm/panels/panel_frame_view.cc#newcode61 ash/wm/panels/panel_frame_view.cc:61: // Reserve enough space to see ...
7 years, 2 months ago (2013-09-30 20:20:25 UTC) #2
pkotwicz
James, can you please take a look at the changes in chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc https://codereview.chromium.org/25270004/diff/1/ash/wm/panels/panel_frame_view.cc File ash/wm/panels/panel_frame_view.cc ...
7 years, 2 months ago (2013-10-01 15:55:04 UTC) #3
James Cook
lgtm with nit https://codereview.chromium.org/25270004/diff/7001/ash/wm/panels/panel_frame_view.cc File ash/wm/panels/panel_frame_view.cc (right): https://codereview.chromium.org/25270004/diff/7001/ash/wm/panels/panel_frame_view.cc#newcode67 ash/wm/panels/panel_frame_view.cc:67: nit: one blank line
7 years, 2 months ago (2013-10-01 16:00:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/25270004/14001
7 years, 2 months ago (2013-10-01 16:28:26 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
7 years, 2 months ago (2013-10-02 01:02:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/25270004/14001
7 years, 2 months ago (2013-10-02 03:18:46 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 06:55:03 UTC) #8
Message was sent while issue was closed. 
Change committed as 226407

Powered by Google App Engine
This is Rietveld 408576698