Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: content/browser/loader/stream_resource_handler.h

Issue 2526983002: Refactor ResourceHandler API. (Closed)
Patch Set: Response to comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/stream_resource_handler.h
diff --git a/content/browser/loader/stream_resource_handler.h b/content/browser/loader/stream_resource_handler.h
index 4f6201f1b2a73c32ba9a4e3575b95413491fc963..719c30bceb67764f22af2c02af8f69e8debf5758 100644
--- a/content/browser/loader/stream_resource_handler.h
+++ b/content/browser/loader/stream_resource_handler.h
@@ -18,6 +18,7 @@ class URLRequest;
namespace content {
+class ResourceController;
class StreamRegistry;
// Redirect this resource to a stream.
@@ -31,16 +32,18 @@ class StreamResourceHandler : public ResourceHandler {
const GURL& origin);
~StreamResourceHandler() override;
- void SetController(ResourceController* controller) override;
-
// Not needed, as this event handler ought to be the final resource.
- bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
- ResourceResponse* resp,
- bool* defer) override;
+ void OnRequestRedirected(
+ const net::RedirectInfo& redirect_info,
+ ResourceResponse* resp,
+ std::unique_ptr<ResourceController> controller) override;
- bool OnResponseStarted(ResourceResponse* resp, bool* defer) override;
+ void OnResponseStarted(
+ ResourceResponse* resp,
+ std::unique_ptr<ResourceController> controller) override;
- bool OnWillStart(const GURL& url, bool* defer) override;
+ void OnWillStart(const GURL& url,
+ std::unique_ptr<ResourceController> controller) override;
// Create a new buffer to store received data.
bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
@@ -48,10 +51,12 @@ class StreamResourceHandler : public ResourceHandler {
int min_size) override;
// A read was completed, forward the data to the Stream.
- bool OnReadCompleted(int bytes_read, bool* defer) override;
+ void OnReadCompleted(int bytes_read,
+ std::unique_ptr<ResourceController> controller) override;
- void OnResponseCompleted(const net::URLRequestStatus& status,
- bool* defer) override;
+ void OnResponseCompleted(
+ const net::URLRequestStatus& status,
+ std::unique_ptr<ResourceController> controller) override;
void OnDataDownloaded(int bytes_downloaded) override;
« no previous file with comments | « content/browser/loader/resource_loader_unittest.cc ('k') | content/browser/loader/stream_resource_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698