Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: content/browser/loader/resource_handler.cc

Issue 2526983002: Refactor ResourceHandler API. (Closed)
Patch Set: Response to comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_handler.h ('k') | content/browser/loader/resource_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_handler.cc
diff --git a/content/browser/loader/resource_handler.cc b/content/browser/loader/resource_handler.cc
index 896809a3d2d334001d4d3f5fb92352b2657de096..961934d05e9f37a9f1315ae2a8862402894d5aa7 100644
--- a/content/browser/loader/resource_handler.cc
+++ b/content/browser/loader/resource_handler.cc
@@ -8,15 +8,48 @@
namespace content {
+ResourceHandler::Delegate::Delegate() {}
+
+ResourceHandler::Delegate::~Delegate() {}
+
+void ResourceHandler::SetDelegate(Delegate* delegate) {
+ delegate_ = delegate;
+}
+
ResourceHandler::~ResourceHandler() {}
ResourceHandler::ResourceHandler(net::URLRequest* request)
- : controller_(NULL),
- request_(request) {
+ : request_(request) {}
+
+void ResourceHandler::HoldController(
+ std::unique_ptr<ResourceController> controller) {
+ controller_ = std::move(controller);
+}
+
+std::unique_ptr<ResourceController> ResourceHandler::ReleaseController() {
+ DCHECK(controller_);
+
+ return std::move(controller_);
+}
+
+void ResourceHandler::Resume() {
+ ReleaseController()->Resume();
+}
+
+void ResourceHandler::Cancel() {
+ ReleaseController()->Cancel();
+}
+
+void ResourceHandler::CancelAndIgnore() {
+ ReleaseController()->CancelAndIgnore();
+}
+
+void ResourceHandler::CancelWithError(int error_code) {
+ ReleaseController()->CancelWithError(error_code);
}
-void ResourceHandler::SetController(ResourceController* controller) {
- controller_ = controller;
+void ResourceHandler::OutOfBandCancel(int error_code, bool tell_renderer) {
+ delegate_->OutOfBandCancel(error_code, tell_renderer);
}
ResourceRequestInfoImpl* ResourceHandler::GetRequestInfo() const {
« no previous file with comments | « content/browser/loader/resource_handler.h ('k') | content/browser/loader/resource_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698