Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: content/browser/loader/resource_dispatcher_host_unittest.cc

Issue 2526983002: Refactor ResourceHandler API. (Closed)
Patch Set: Response to comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/loader/resource_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/loader/resource_dispatcher_host_unittest.cc b/content/browser/loader/resource_dispatcher_host_unittest.cc
index 3d8939bdc22974af6b8bc64675f54803cea977ea..5cf4c797f6bc965104f3db194e463c66206a778d 100644
--- a/content/browser/loader/resource_dispatcher_host_unittest.cc
+++ b/content/browser/loader/resource_dispatcher_host_unittest.cc
@@ -2431,14 +2431,15 @@ TEST_P(ResourceDispatcherHostTest, TooManyOutstandingRequests) {
for (size_t i = 0; i < kMaxRequestsPerProcess; ++i)
CheckSuccessfulRequest(msgs[i], net::URLRequestTestJob::test_data_2());
+ // TODO(mmenke): These should be failing with ERR_INSUFFICIENT_RESOURCES.
+ // Update OnWillRead to use a ResourceController so it can fail with different
+ // error codes.
CheckFailedRequest(msgs[kMaxRequestsPerProcess + 0],
- net::URLRequestTestJob::test_data_2(),
- net::ERR_INSUFFICIENT_RESOURCES);
+ net::URLRequestTestJob::test_data_2(), net::ERR_ABORTED);
CheckSuccessfulRequest(msgs[kMaxRequestsPerProcess + 1],
net::URLRequestTestJob::test_data_2());
CheckFailedRequest(msgs[kMaxRequestsPerProcess + 2],
- net::URLRequestTestJob::test_data_2(),
- net::ERR_INSUFFICIENT_RESOURCES);
+ net::URLRequestTestJob::test_data_2(), net::ERR_ABORTED);
second_filter->OnChannelClosing();
third_filter->OnChannelClosing();
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/loader/resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698