Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: content/browser/loader/mock_resource_loader.h

Issue 2526983002: Refactor ResourceHandler API. (Closed)
Patch Set: Response to comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/mock_resource_loader.h
diff --git a/content/browser/loader/mock_resource_loader.h b/content/browser/loader/mock_resource_loader.h
index a22728197c6fef6d05211132bb5bda412f7b756f..b3e962e8344c06bca2de4342368d239385dca8bd 100644
--- a/content/browser/loader/mock_resource_loader.h
+++ b/content/browser/loader/mock_resource_loader.h
@@ -10,9 +10,11 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
#include "base/run_loop.h"
#include "base/strings/string_piece.h"
#include "content/browser/loader/resource_controller.h"
+#include "content/browser/loader/resource_handler.h"
#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
@@ -24,13 +26,12 @@ class URLRequestStatus;
}
namespace content {
-class ResourceHandler;
struct ResourceResponse;
// Class that takes the place of the ResourceLoader for tests. It simplifies
// testing ResourceHandlers by managing callbacks and performing basic sanity
// checks. The test fixture is responsible for advancing states.
-class MockResourceLoader : public ResourceController {
+class MockResourceLoader : public ResourceHandler::Delegate {
public:
explicit MockResourceLoader(ResourceHandler* resource_handler);
~MockResourceLoader() override;
@@ -85,22 +86,27 @@ class MockResourceLoader : public ResourceController {
int io_buffer_size() const { return io_buffer_size_; }
private:
- // ResourceController implementation.
- void Cancel() override;
- void CancelAndIgnore() override;
- void CancelWithError(int error_code) override;
- void Resume() override;
+ class TestResourceController;
+
+ // ResourceHandler::Delegate implementation:
+ void OutOfBandCancel(int error_code, bool tell_renderer) override;
+
+ void OnCancel(int error_code);
+ void OnResume();
ResourceHandler* const resource_handler_;
Status status_ = Status::IDLE;
int error_code_ = net::OK;
+ bool canceled_out_of_band_ = false;
scoped_refptr<net::IOBuffer> io_buffer_;
int io_buffer_size_ = 0;
std::unique_ptr<base::RunLoop> canceled_or_idle_run_loop_;
+ base::WeakPtrFactory<MockResourceLoader> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(MockResourceLoader);
};
« no previous file with comments | « content/browser/loader/mime_sniffing_resource_handler.cc ('k') | content/browser/loader/mock_resource_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698