Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: content/browser/loader/async_resource_handler.h

Issue 2526983002: Refactor ResourceHandler API. (Closed)
Patch Set: Silly merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/async_resource_handler.h
diff --git a/content/browser/loader/async_resource_handler.h b/content/browser/loader/async_resource_handler.h
index a664c3e9927e6b972f639d399c1a076b8ee72828..0c976bd0ee1aa20d1a7729f7a147cf640b63555f 100644
--- a/content/browser/loader/async_resource_handler.h
+++ b/content/browser/loader/async_resource_handler.h
@@ -25,6 +25,7 @@ class UploadProgress;
namespace content {
class ResourceBuffer;
+class ResourceController;
class ResourceDispatcherHostImpl;
class UploadProgressTracker;
@@ -40,17 +41,23 @@ class CONTENT_EXPORT AsyncResourceHandler : public ResourceHandler,
bool OnMessageReceived(const IPC::Message& message) override;
// ResourceHandler implementation:
- bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
- ResourceResponse* response,
- bool* defer) override;
- bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
- bool OnWillStart(const GURL& url, bool* defer) override;
+ void OnRequestRedirected(
+ const net::RedirectInfo& redirect_info,
+ ResourceResponse* response,
+ std::unique_ptr<ResourceController> controller) override;
+ void OnResponseStarted(
+ ResourceResponse* response,
+ std::unique_ptr<ResourceController> controller) override;
+ void OnWillStart(const GURL& url,
+ std::unique_ptr<ResourceController> controller) override;
bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
int* buf_size,
int min_size) override;
- bool OnReadCompleted(int bytes_read, bool* defer) override;
- void OnResponseCompleted(const net::URLRequestStatus& status,
- bool* defer) override;
+ void OnReadCompleted(int bytes_read,
+ std::unique_ptr<ResourceController> controller) override;
+ void OnResponseCompleted(
+ const net::URLRequestStatus& status,
+ std::unique_ptr<ResourceController> controller) override;
void OnDataDownloaded(int bytes_downloaded) override;
private:
@@ -85,8 +92,6 @@ class CONTENT_EXPORT AsyncResourceHandler : public ResourceHandler,
bool first_chunk_read_ = false;
- bool did_defer_;
-
bool has_checked_for_sufficient_resources_;
bool sent_received_response_msg_;
bool sent_data_buffer_msg_;

Powered by Google App Engine
This is Rietveld 408576698