Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/browser/loader/redirect_to_file_resource_handler.h

Issue 2526983002: Refactor ResourceHandler API. (Closed)
Patch Set: Fix stuff Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/redirect_to_file_resource_handler.h
diff --git a/content/browser/loader/redirect_to_file_resource_handler.h b/content/browser/loader/redirect_to_file_resource_handler.h
index bcda474616fb8d57364674a7f0d82dd5b442cd0f..cadf1eb5f57bd499210ac44955ae5b9ee1b4d698 100644
--- a/content/browser/loader/redirect_to_file_resource_handler.h
+++ b/content/browser/loader/redirect_to_file_resource_handler.h
@@ -32,6 +32,8 @@ class ShareableFileReference;
namespace content {
+class ResourceController;
+
// Redirects network data to a file. This is intended to be layered in front of
// either the AsyncResourceHandler or the SyncResourceHandler. The downstream
// resource handler does not see OnWillRead or OnReadCompleted calls. Instead,
@@ -57,14 +59,19 @@ class CONTENT_EXPORT RedirectToFileResourceHandler
const CreateTemporaryFileStreamFunction& create_temporary_file_stream);
// LayeredResourceHandler implementation:
- bool OnResponseStarted(ResourceResponse* response, bool* defer) override;
- bool OnWillStart(const GURL& url, bool* defer) override;
+ void OnResponseStarted(
+ ResourceResponse* response,
+ std::unique_ptr<ResourceController> controller) override;
+ void OnWillStart(const GURL& url,
+ std::unique_ptr<ResourceController> controller) override;
bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
int* buf_size,
int min_size) override;
- bool OnReadCompleted(int bytes_read, bool* defer) override;
- void OnResponseCompleted(const net::URLRequestStatus& status,
- bool* defer) override;
+ void OnReadCompleted(int bytes_read,
+ std::unique_ptr<ResourceController> controller) override;
+ void OnResponseCompleted(
+ const net::URLRequestStatus& status,
+ std::unique_ptr<ResourceController> controller) override;
private:
void DidCreateTemporaryFile(base::File::Error error_code,
@@ -104,8 +111,6 @@ class CONTENT_EXPORT RedirectToFileResourceHandler
// was filled, up to a maximum size of 512k.
int next_buffer_size_;
- bool did_defer_;
-
bool completed_during_write_;
GURL will_start_url_;
net::URLRequestStatus completed_status_;

Powered by Google App Engine
This is Rietveld 408576698