Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: content/browser/loader/stream_writer.cc

Issue 2526983002: Refactor ResourceHandler API. (Closed)
Patch Set: Response to comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/loader/stream_writer.h ('k') | content/browser/loader/sync_resource_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/loader/stream_writer.h" 5 #include "content/browser/loader/stream_writer.h"
6 6
7 #include "base/callback_helpers.h"
7 #include "base/guid.h" 8 #include "base/guid.h"
8 #include "content/browser/loader/resource_controller.h" 9 #include "content/browser/loader/resource_controller.h"
9 #include "content/browser/streams/stream.h" 10 #include "content/browser/streams/stream.h"
10 #include "content/browser/streams/stream_registry.h" 11 #include "content/browser/streams/stream_registry.h"
11 #include "net/base/io_buffer.h" 12 #include "net/base/io_buffer.h"
12 #include "url/gurl.h" 13 #include "url/gurl.h"
13 #include "url/url_constants.h" 14 #include "url/url_constants.h"
14 15
15 namespace content { 16 namespace content {
16 17
17 StreamWriter::StreamWriter() : controller_(nullptr), immediate_mode_(false) { 18 StreamWriter::StreamWriter() : immediate_mode_(false) {}
18 }
19 19
20 StreamWriter::~StreamWriter() { 20 StreamWriter::~StreamWriter() {
21 if (stream_.get()) 21 if (stream_.get())
22 Finalize(0); 22 Finalize(0);
23 } 23 }
24 24
25 void StreamWriter::InitializeStream(StreamRegistry* registry, 25 void StreamWriter::InitializeStream(StreamRegistry* registry,
26 const GURL& origin) { 26 const GURL& origin,
27 const base::Closure& cancel_callback) {
28 cancel_callback_ = cancel_callback;
27 DCHECK(!stream_.get()); 29 DCHECK(!stream_.get());
28 30
29 // TODO(tyoshino): Find a way to share this with the blob URL creation in 31 // TODO(tyoshino): Find a way to share this with the blob URL creation in
30 // WebKit. 32 // WebKit.
31 GURL url(std::string(url::kBlobScheme) + ":" + origin.spec() + 33 GURL url(std::string(url::kBlobScheme) + ":" + origin.spec() +
32 base::GenerateGUID()); 34 base::GenerateGUID());
33 stream_ = new Stream(registry, this, url); 35 stream_ = new Stream(registry, this, url);
34 } 36 }
35 37
36 void StreamWriter::OnWillRead(scoped_refptr<net::IOBuffer>* buf, 38 void StreamWriter::OnWillRead(scoped_refptr<net::IOBuffer>* buf,
37 int* buf_size, 39 int* buf_size,
38 int min_size) { 40 int min_size) {
39 static const int kReadBufSize = 32768; 41 static const int kReadBufSize = 32768;
40 42
41 DCHECK(buf); 43 DCHECK(buf);
42 DCHECK(buf_size); 44 DCHECK(buf_size);
43 DCHECK_LE(min_size, kReadBufSize); 45 DCHECK_LE(min_size, kReadBufSize);
44 if (!read_buffer_.get()) 46 if (!read_buffer_.get())
45 read_buffer_ = new net::IOBuffer(kReadBufSize); 47 read_buffer_ = new net::IOBuffer(kReadBufSize);
46 *buf = read_buffer_.get(); 48 *buf = read_buffer_.get();
47 *buf_size = kReadBufSize; 49 *buf_size = kReadBufSize;
48 } 50 }
49 51
50 void StreamWriter::OnReadCompleted(int bytes_read, bool* defer) { 52 void StreamWriter::OnReadCompleted(
51 if (!bytes_read) 53 int bytes_read,
54 const base::Closure& need_more_data_callback) {
55 DCHECK(!need_more_data_callback_);
56 if (!bytes_read) {
57 need_more_data_callback.Run();
52 return; 58 return;
59 }
53 60
54 // We have more data to read. 61 // We have more data to read.
55 DCHECK(read_buffer_.get()); 62 DCHECK(read_buffer_.get());
56 63
57 // Release the ownership of the buffer, and store a reference 64 // Release the ownership of the buffer, and store a reference
58 // to it. A new one will be allocated in OnWillRead(). 65 // to it. A new one will be allocated in OnWillRead().
59 scoped_refptr<net::IOBuffer> buffer; 66 scoped_refptr<net::IOBuffer> buffer;
60 read_buffer_.swap(buffer); 67 read_buffer_.swap(buffer);
61 stream_->AddData(buffer, bytes_read); 68 stream_->AddData(buffer, bytes_read);
62 69
63 if (immediate_mode_) 70 if (immediate_mode_)
64 stream_->Flush(); 71 stream_->Flush();
65 72
66 if (!stream_->can_add_data()) 73 if (!stream_->can_add_data()) {
67 *defer = true; 74 need_more_data_callback_ = need_more_data_callback;
75 return;
76 }
77 need_more_data_callback.Run();
68 } 78 }
69 79
70 void StreamWriter::Finalize(int status) { 80 void StreamWriter::Finalize(int status) {
71 DCHECK(stream_.get()); 81 DCHECK(stream_.get());
72 stream_->Finalize(status); 82 stream_->Finalize(status);
73 stream_->RemoveWriteObserver(this); 83 stream_->RemoveWriteObserver(this);
74 stream_ = nullptr; 84 stream_ = nullptr;
75 } 85 }
76 86
77 void StreamWriter::OnSpaceAvailable(Stream* stream) { 87 void StreamWriter::OnSpaceAvailable(Stream* stream) {
78 controller_->Resume(); 88 base::ResetAndReturn(&need_more_data_callback_).Run();
79 } 89 }
80 90
81 void StreamWriter::OnClose(Stream* stream) { 91 void StreamWriter::OnClose(Stream* stream) {
82 controller_->Cancel(); 92 cancel_callback_.Run();
83 } 93 }
84 94
85 } // namespace content 95 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/stream_writer.h ('k') | content/browser/loader/sync_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698