Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc

Issue 2526973002: Added retry policy (Closed)
Patch Set: Fixed GN problem Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/enrollment/enrollment_screen.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc
diff --git a/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc b/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f1116c2172d10fc104173e29ab6d05d4e0dcfb4f
--- /dev/null
+++ b/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc
@@ -0,0 +1,177 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/login/enrollment/enrollment_screen.h"
+#include "base/bind.h"
+#include "base/command_line.h"
+#include "base/message_loop/message_loop.h"
+#include "base/test/scoped_mock_time_message_loop_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.h"
+#include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.h"
+#include "chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h"
+#include "chrome/browser/chromeos/login/screens/mock_base_screen_delegate.h"
+#include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
+#include "chrome/browser/chromeos/policy/enrollment_config.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chromeos/chromeos_switches.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "components/pairing/fake_controller_pairing_controller.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::AnyNumber;
+using testing::Invoke;
+
+namespace chromeos {
+
+class EnrollmentScreenUnitTest : public testing::Test {
+ public:
+ EnrollmentScreenUnitTest() : fake_controller_("") {
+ enrollment_config_.mode = policy::EnrollmentConfig::MODE_ATTESTATION_FORCED;
+ enrollment_config_.auth_mechanism =
+ policy::EnrollmentConfig::AUTH_MECHANISM_ATTESTATION;
+ }
+
+ // Closure passed to EnterpriseEnrollmentHelper::SetupEnrollmentHelperMock
+ // which creates the EnterpriseEnrollmentHelperMock object that will
+ // eventually be tied to the EnrollmentScreen. It also sets up the
+ // appropriate expectations for testing with the Google Mock framework.
+ // The template parameter should_enroll indicates whether or not
+ // the EnterpriseEnrollmentHelper should be mocked to successfully enroll.
+ template <bool should_enroll>
+ static EnterpriseEnrollmentHelper* MockEnrollmentHelperCreator(
+ EnterpriseEnrollmentHelper::EnrollmentStatusConsumer* status_consumer,
+ const policy::EnrollmentConfig& enrollment_config,
+ const std::string& enrolling_user_domain) {
+ EnterpriseEnrollmentHelperMock* mock =
+ new EnterpriseEnrollmentHelperMock(status_consumer);
+ if (should_enroll) {
+ EXPECT_CALL(*mock, EnrollUsingAttestation())
+ .Times(AnyNumber())
+ .WillRepeatedly(Invoke([mock]() {
+ static_cast<EnrollmentScreen*>(mock->status_consumer())
+ ->ShowEnrollmentStatusOnSuccess();
+ }));
+ } else {
+ EXPECT_CALL(*mock, EnrollUsingAttestation())
+ .Times(AnyNumber())
+ .WillRepeatedly(Invoke([mock]() {
+ mock->status_consumer()->OnEnrollmentError(
+ policy::EnrollmentStatus::ForStatus(
+ policy::EnrollmentStatus::REGISTRATION_FAILED));
+ }));
+ }
+ return mock;
+ }
+
+ // Creates the EnrollmentScreen and sets required parameters.
+ void SetUpEnrollmentScreen() {
+ enrollment_screen_.reset(
+ new EnrollmentScreen(&mock_delegate_, &mock_actor_));
+ enrollment_screen_->SetParameters(enrollment_config_, &fake_controller_);
+ }
+
+ // Fast forwards time by the specified amount.
+ void FastForwardTime(base::TimeDelta time) {
+ runner_.task_runner()->FastForwardBy(time);
+ }
+
+ // testing::Test:
+ void SetUp() override {
+ // Initialize the thread manager.
+ DBusThreadManager::Initialize();
+
+ // Configure the browser to use Hands-Off Enrollment.
+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ switches::kEnterpriseEnableZeroTouchEnrollment, "hands-off");
+ }
+
+ void TearDown() override {
+ TestingBrowserProcess::GetGlobal()->SetShuttingDown(true);
+ DBusThreadManager::Shutdown();
+ }
+
+ protected:
+ // A pointer to the EnrollmentScreen.
+ std::unique_ptr<EnrollmentScreen> enrollment_screen_;
+
+ private:
+ // Replace main thread's task runner with a mock for duration of test.
+ base::MessageLoop loop_;
+ base::ScopedMockTimeMessageLoopTaskRunner runner_;
+
+ // Objects required by the EnrollmentScreen that can be re-used.
+ policy::EnrollmentConfig enrollment_config_;
+ pairing_chromeos::FakeControllerPairingController fake_controller_;
+ MockBaseScreenDelegate mock_delegate_;
+ MockEnrollmentScreenActor mock_actor_;
+
+ DISALLOW_COPY_AND_ASSIGN(EnrollmentScreenUnitTest);
+};
+
+TEST_F(EnrollmentScreenUnitTest, Retries) {
+ // Define behavior of EnterpriseEnrollmentHelperMock to always fail
+ // enrollment.
+ EnterpriseEnrollmentHelper::SetupEnrollmentHelperMock(
+ &EnrollmentScreenUnitTest::MockEnrollmentHelperCreator<false>);
+
+ SetUpEnrollmentScreen();
+
+ // Remove jitter to enable deterministic testing.
+ enrollment_screen_->retry_policy_.jitter_factor = 0;
+
+ // Start zero-touch enrollment.
+ enrollment_screen_->Show();
+
+ // Fast forward time by 1 minute.
+ FastForwardTime(base::TimeDelta::FromMinutes(1));
+
+ // Check that we have retried 4 times.
+ EXPECT_EQ(enrollment_screen_->num_retries_, 4);
+}
+
+TEST_F(EnrollmentScreenUnitTest, DoesNotRetryOnTopOfUser) {
+ // Define behavior of EnterpriseEnrollmentHelperMock to always fail
+ // enrollment.
+ EnterpriseEnrollmentHelper::SetupEnrollmentHelperMock(
+ &EnrollmentScreenUnitTest::MockEnrollmentHelperCreator<false>);
+
+ SetUpEnrollmentScreen();
+
+ // Remove jitter to enable deterministic testing.
+ enrollment_screen_->retry_policy_.jitter_factor = 0;
+
+ // Start zero-touch enrollment.
+ enrollment_screen_->Show();
+
+ // Schedule user retry button click after 30 sec.
+ base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
+ FROM_HERE, base::Bind(&EnrollmentScreen::OnRetry,
+ enrollment_screen_->weak_ptr_factory_.GetWeakPtr()),
+ base::TimeDelta::FromSeconds(30));
+
+ // Fast forward time by 1 minute.
+ FastForwardTime(base::TimeDelta::FromMinutes(1));
+
+ // Check that the number of retries is still 4.
+ EXPECT_EQ(enrollment_screen_->num_retries_, 4);
+}
+
+TEST_F(EnrollmentScreenUnitTest, DoesNotRetryAfterSuccess) {
+ // Define behavior of EnterpriseEnrollmentHelperMock to successfully enroll.
+ EnterpriseEnrollmentHelper::SetupEnrollmentHelperMock(
+ &EnrollmentScreenUnitTest::MockEnrollmentHelperCreator<true>);
+
+ SetUpEnrollmentScreen();
+
+ // Start zero-touch enrollment.
+ enrollment_screen_->Show();
+
+ // Fast forward time by 1 minute.
+ FastForwardTime(base::TimeDelta::FromMinutes(1));
+
+ // Check that we do not retry.
+ EXPECT_EQ(enrollment_screen_->num_retries_, 0);
+}
+} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/enrollment/enrollment_screen.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698