Added retry policy

chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.cc

Index: chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.cc
diff --git a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.cc b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.cc
index b3a45e2ef0e9c15cc93c1315f838e1b9c34b71e3..4f889c09afb224d234dbf25146abfad99309ecff 100644
--- a/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.cc
+++ b/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.cc
@@ -3,7 +3,9 @@
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_mock.h"
+#include "chrome/browser/chromeos/login/enrollment/enrollment_screen.h"
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h"
+#include "chrome/browser/chromeos/policy/enrollment_status_chromeos.h"
 
 namespace chromeos {
 
@@ -18,4 +20,14 @@ EnterpriseEnrollmentHelperMock::status_consumer() {
   return EnterpriseEnrollmentHelper::status_consumer();
 }
 
+void EnterpriseEnrollmentHelperMock::SucceedEnrollment() {
+  static_cast<EnrollmentScreen*>(status_consumer())

[xiyuan, 2017/02/03 23:34:15]

static_cast should be avoided. Can you call
  status_consumer()->OnDeviceAttributeUpdatePermission(false)

instead?

[kumarniranjan, 2017/02/06 21:38:25]

The method OnDeviceAttributeUpdatePermission is not defined in
EnrollmentStatusConsumer. It is only defined in EnrollmentScreen.
So, unfortunately, I cannot remove the static cast.

[xiyuan, 2017/02/06 23:05:33]

It seems to be part of EnrollmentStatusConsumer [1]. What did I miss?

[1]:
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/enrollment...

[kumarniranjan, 2017/02/06 23:35:12]

Sorry, I meant that ShowEnrollmentStatusOnSuccess is only defined in
EnrollmentScreen.

However, when I try replacing ShowEnrollmentStatusOnSuccess() with
OnDeviceAttributeUpdatePermission(false), I get a Segmentation fault.

It originates from the StartupUtils call here
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/enrollment...

StartupUtils probably doesn't work as expected since, in this unit test, I did
not do the full initialization work that is done during normal Chrome browser
startup.

[xiyuan, 2017/02/06 23:46:05]

Thank you for trying it out.

static_cast makes EnterpriseEnrollmentHelperMock assume it must have a status
consumer that could be casted to a EnrollmentScreen. This could be somewhat
unexpected for future user of the mock class.

How about deriving a mock class from EnterpriseEnrollmentHelperMock in your
test? I am fine with doing the static_cast there since it has limited impact.

[kumarniranjan, 2017/02/07 21:26:00]

I came up with a solution using anonymous functions. This way, I do not need to
put unexpected constraints on users of EnterpriseEnrollmentHelperMock, while at
the same time avoiding the creation of a whole new class just for one test.

+      ->ShowEnrollmentStatusOnSuccess();
+}
+
+void EnterpriseEnrollmentHelperMock::FailEnrollment() {
+  status_consumer()->OnEnrollmentError(policy::EnrollmentStatus::ForStatus(
+      policy::EnrollmentStatus::REGISTRATION_FAILED));
+}
+
 }  // namespace chromeos