Added retry policy

chrome/browser/chromeos/login/enrollment/enrollment_screen.h

Index: chrome/browser/chromeos/login/enrollment/enrollment_screen.h
diff --git a/chrome/browser/chromeos/login/enrollment/enrollment_screen.h b/chrome/browser/chromeos/login/enrollment/enrollment_screen.h
index 9bd361d02b6e9e8e6dcc67087a95b164bba53c67..aef07191565dbeacf05ee96704abfe5a7291b4d3 100644
--- a/chrome/browser/chromeos/login/enrollment/enrollment_screen.h
+++ b/chrome/browser/chromeos/login/enrollment/enrollment_screen.h
@@ -13,12 +13,14 @@
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
+#include "base/timer/timer.h"
 #include "chrome/browser/chromeos/login/enrollment/enrollment_screen_actor.h"
 #include "chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper.h"
 #include "chrome/browser/chromeos/login/screens/base_screen.h"
 #include "chrome/browser/chromeos/policy/enrollment_config.h"
 #include "components/policy/core/common/cloud/cloud_policy_constants.h"
 #include "components/policy/core/common/cloud/enterprise_metrics.h"
+#include "net/base/backoff_entry.h"
 
 namespace base {
 class ElapsedTimer;
@@ -157,7 +159,10 @@ class EnrollmentScreen
   std::string enrolling_user_domain_;
   std::string auth_code_;
   std::unique_ptr<base::ElapsedTimer> elapsed_timer_;
+  base::OneShotTimer timer_;

[joth, 2016/11/23 22:24:03]

This object can only be used for one thing at a time, so lets call it
retry_timer_

[kumarniranjan, 2016/11/24 18:12:46]

Done.

   std::unique_ptr<EnterpriseEnrollmentHelper> enrollment_helper_;
+  net::BackoffEntry* backoff_;
+  net::BackoffEntry::Policy* policy_;

[joth, 2016/11/23 22:24:03]

suggest grouping the timer with these, and prefix all the names -- 
retry_backoff_ retry_policy_ retry_timer_

[joth, 2016/11/23 22:24:03]

Don't use naked pointers here, either use unique_ptr to ensure deletion, or even
simpler just put the objects directly in as members of the class:
 net::BackoffEntry::Policy retry_policy_;
 net::BackoffEntry retry_backoff_;

(policy then needs to be before the backoff entry, to ensure it is constructed
before it)

[The one and only Dr. Crash, 2016/11/23 23:00:15]

I agree re: using objects here.

Also it seems that policy_ is only used in the constructor to build backoff_. If
so, are you able to actually build the policy there and transfer ownership to
backoff?

[kumarniranjan, 2016/11/24 18:12:46]

I decided to put the objects directly in as members of the class. I don't
believe there is a way of building the policy in the constructor and
transferring ownership to the BackoffEntry object without creating a new
constructor for BackoffEntry

   base::WeakPtrFactory<EnrollmentScreen> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(EnrollmentScreen);