Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: media/mojo/interfaces/video_decoder.mojom

Issue 2526953003: Add MediaGpuChannelManager::LookupChannel(). (Closed)
Patch Set: Implement MockGpuVideoAcceleratorFactories::GetCommandBufferRouteId(). Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/clients/mojo_video_decoder.cc ('k') | media/mojo/services/gpu_mojo_media_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/interfaces/video_decoder.mojom
diff --git a/media/mojo/interfaces/video_decoder.mojom b/media/mojo/interfaces/video_decoder.mojom
index b0bcf94b4d6718fd16faa56af3ff2b6f03848ab5..42261246c5b407b853fd05b18791912a7bf81b87 100644
--- a/media/mojo/interfaces/video_decoder.mojom
+++ b/media/mojo/interfaces/video_decoder.mojom
@@ -5,17 +5,30 @@
module media.mojom;
import "media/mojo/interfaces/media_types.mojom";
+import "mojo/common/unguessable_token.mojom";
+
+// Identifies a GpuCommandBufferStub. MediaGpuChannelManager is responsible
+// for minting |channel_token| objects.
+struct CommandBufferId {
+ mojo.common.mojom.UnguessableToken channel_token;
+ int32 route_id;
+};
interface VideoDecoder {
// Initialize the decoder. This must be called before any other method.
//
+ // |command_buffer_id|, when present, identifies a GpuCommandBufferStub that
+ // the decoder can use for GL operations. Implementations that require GL will
+ // fail Initialize() if |command_buffer_id| is not provided.
+ //
// |decoder_buffer_pipe| will be used to transfer encoded data for each
// DecoderBuffer.
//
// TODO(sandersd): Rename to Initialize() if/when
// media::VideoDecoder::Initialize() is renamed to Configure().
Construct(associated VideoDecoderClient client,
- handle<data_pipe_consumer> decoder_buffer_pipe);
+ handle<data_pipe_consumer> decoder_buffer_pipe,
+ CommandBufferId? command_buffer_id);
// Configure (or reconfigure) the decoder. This must be called before decoding
// any frames, and must not be called while there are pending Initialize(),
« no previous file with comments | « media/mojo/clients/mojo_video_decoder.cc ('k') | media/mojo/services/gpu_mojo_media_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698