Add MediaGpuChannelManager::LookupChannel().

media/mojo/services/mojo_video_decoder_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/mojo/services/mojo_video_decoder_service.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/threading/thread_task_runner_handle.h"
@@ skipping 13 matching lines @@
 MojoVideoDecoderService::MojoVideoDecoderService(
     MojoMediaClient* mojo_media_client)
     : mojo_media_client_(mojo_media_client), weak_factory_(this) {
   weak_this_ = weak_factory_.GetWeakPtr();
 }
 
 MojoVideoDecoderService::~MojoVideoDecoderService() {}
 
 void MojoVideoDecoderService::Construct(
     mojom::VideoDecoderClientAssociatedPtrInfo client,
-    mojo::ScopedDataPipeConsumerHandle decoder_buffer_pipe) {
+    mojo::ScopedDataPipeConsumerHandle decoder_buffer_pipe,
+    mojom::CommandBufferIdPtr command_buffer_id) {
   DVLOG(1) << __func__;
 
+  // TODO(sandersd): Enter an error state.

[dcheng, 2017/01/11 09:14:18]

What does this mean?

[sandersd (OOO until July 31), 2017/01/11 21:33:09]

The client should not have called this method at this time; we should probably
be disconnecting them. At the time this was written we didn't have a complete
story for how such errors should be handled. (We have most of a plan now, but it
wasn't critical to include in this CL.)

[dcheng, 2017/01/11 22:01:59]

Out of curiosity, how will they be handled? =)

[sandersd (OOO until July 31), 2017/01/11 22:21:31]

The plan is to pass a callback into the constructor that will close the string
binding (which for media services is owned by a StrongBindingSet); we will just
call that for incorrect API usage. In any egregious cases (I don't think
MojoVideoDecoder has any), the plan is to also call ReportBadMessage().

   if (decoder_)
     return;
 
   // TODO(sandersd): Provide callback for requesting a GpuCommandBufferStub.
   decoder_ = mojo_media_client_->CreateVideoDecoder(
-      base::ThreadTaskRunnerHandle::Get());
+      base::ThreadTaskRunnerHandle::Get(), std::move(command_buffer_id));
 
   client_.Bind(std::move(client));
 
   mojo_decoder_buffer_reader_.reset(
       new MojoDecoderBufferReader(std::move(decoder_buffer_pipe)));
 }
 
 void MojoVideoDecoderService::Initialize(mojom::VideoDecoderConfigPtr config,
                                          bool low_delay,
                                          const InitializeCallback& callback) {
@@ skipping 75 matching lines @@
 }
 
 void MojoVideoDecoderService::OnDecoderOutput(
     const scoped_refptr<VideoFrame>& frame) {
   DVLOG(2) << __func__;
   DCHECK(client_);
   client_->OnVideoFrameDecoded(mojom::VideoFrame::From(frame));
 }
 
 }  // namespace media