Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.cc

Issue 2526943003: [Payments] Remove country from shipping label in bottom and fullsheet. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/android/personal_data_manager_android.cc
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.cc b/chrome/browser/autofill/android/personal_data_manager_android.cc
index 7de6fd815d4a1155705443f4fda2f1925919d198..42a3289986433a084c219ab35572d4e9ec101528 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.cc
+++ b/chrome/browser/autofill/android/personal_data_manager_android.cc
@@ -430,10 +430,28 @@ PersonalDataManagerAndroid::GetProfileLabelsToSuggest(
}
base::android::ScopedJavaLocalRef<jstring>
-PersonalDataManagerAndroid::GetShippingAddressLabelForPaymentRequest(
+PersonalDataManagerAndroid::GetShippingAddressLabelWithCountryForPaymentRequest(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& unused_obj,
const base::android::JavaParamRef<jobject>& jprofile) {
+ return GetShippingAddressLabelForPaymentRequest(
+ env, jprofile, true /* include_country_in_label */);
+}
+
+base::android::ScopedJavaLocalRef<jstring> PersonalDataManagerAndroid::
+ GetShippingAddressLabelWithoutCountryForPaymentRequest(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& unused_obj,
+ const base::android::JavaParamRef<jobject>& jprofile) {
+ return GetShippingAddressLabelForPaymentRequest(
+ env, jprofile, false /* include_country_in_label */);
+}
+
+base::android::ScopedJavaLocalRef<jstring>
+PersonalDataManagerAndroid::GetShippingAddressLabelForPaymentRequest(
please use gerrit instead 2016/11/23 21:40:50 Order of methods in .h should match the order of m
sebsg 2016/11/25 15:55:20 Done.
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& jprofile,
+ bool include_country_in_label) {
// The full name is not included in the label for shipping address. It is
// added separately instead.
std::vector<ServerFieldType> label_fields;
@@ -445,7 +463,8 @@ PersonalDataManagerAndroid::GetShippingAddressLabelForPaymentRequest(
label_fields.push_back(ADDRESS_HOME_STATE);
label_fields.push_back(ADDRESS_HOME_ZIP);
label_fields.push_back(ADDRESS_HOME_SORTING_CODE);
- label_fields.push_back(ADDRESS_HOME_COUNTRY);
+ if (include_country_in_label)
+ label_fields.push_back(ADDRESS_HOME_COUNTRY);
AutofillProfile profile;
PopulateNativeProfileFromJava(jprofile, env, &profile);

Powered by Google App Engine
This is Rietveld 408576698