Fix for 18468- T << Type where T is a type parameter and Type is the type Type from dart.core

editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
index 519d892f4880cc74c16e0695f054e15a4dcf4602..de24c59b3b72647138b28a755eee455d04c4bef2 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
@@ -13,6 +13,8 @@
  */
 package com.google.dart.engine.internal.type;
 
+import com.google.dart.engine.element.Element;
+import com.google.dart.engine.element.LibraryElement;
 import com.google.dart.engine.element.TypeParameterElement;
 import com.google.dart.engine.internal.element.ElementPair;
 import com.google.dart.engine.type.Type;
@@ -35,6 +37,11 @@ public class TypeParameterTypeImpl extends TypeImpl implements TypeParameterType
   public static final TypeParameterType[] EMPTY_ARRAY = new TypeParameterType[0];
 
   /**
+   * The name of the type Type from dart.core.
+   */
+  private static final String TYPE_CLASS_NAME = "Type"; //$NON-NLS-1$
+
+  /**
    * Return an array containing the type parameter types defined by the given array of type
    * parameter elements.
    * 
@@ -131,6 +138,16 @@ public class TypeParameterTypeImpl extends TypeImpl implements TypeParameterType
 
   private boolean isMoreSpecificThan(Type s, Set<Type> visitedTypes, boolean withDynamic,
       Set<TypePair> visitedTypePairs) {
+    //
+    // If s is of type Type from dart.core, return true

[karlklose, 2014/04/30 09:42:40]

This is not correct: [Type] is a normal class and is not more specific than a
type variable.

This change makes Type assignable to any type variable, so this works,  too:
  class C<T> {
    foo() {
      T t = int;
    }
  }

+    //
+    Element sElement = s.getElement();
+    LibraryElement sLibrary = sElement != null ? sElement.getLibrary() : null;
+    if (sLibrary != null && sLibrary.isDartCore() && s.getName().equals(TYPE_CLASS_NAME)) {
+      return true;
+    }
+
+    //
     // T is a type parameter and S is the upper bound of T.
     //
     Type bound = getElement().getBound();
@@ -138,6 +155,7 @@ public class TypeParameterTypeImpl extends TypeImpl implements TypeParameterType
       return true;
     }
 
+    //
     // T is a type parameter and S is Object.
     //
     if (s.isObject()) {