Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 25269006: Initial iframe loads shouldn't add session history items. (Closed)

Created:
7 years, 2 months ago by nasko
Modified:
7 years, 2 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Initial iframe load shouldn't add session history item. This CL is fixing the behavior of setReplacesCurrentHistoryItem for initial frame navigation. The Chromium side change is at https://codereview.chromium.org/15294012/. BUG=178380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158723

Patch Set 1 #

Patch Set 2 : Rewriting the fix in a different way and adding a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1 line) Patch
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +10 lines, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nasko
Hey Darin, This is a follow up from our earlier discussion on how to best ...
7 years, 2 months ago (2013-09-30 20:11:13 UTC) #1
darin (slow to review)
This looks good, but shouldn't there be some kind of regression test? I'm not sure ...
7 years, 2 months ago (2013-09-30 21:12:21 UTC) #2
nasko
I was planning to test this on the Chromium side. Now I know about WebFrameTest, ...
7 years, 2 months ago (2013-10-01 21:42:52 UTC) #3
darin (slow to review)
LGTM
7 years, 2 months ago (2013-10-02 04:32:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/25269006/7001
7 years, 2 months ago (2013-10-02 13:28:53 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 14:24:12 UTC) #6
Message was sent while issue was closed.
Change committed as 158723

Powered by Google App Engine
This is Rietveld 408576698