[MD Extensions] Update subpages when the backing extension data changes

[MD Extensions] Update subpages when the backing extension data changes

Many subpages show some form of details for a given extension. When the
backing data changes, those changes need to be reflected in the open
subpage. Right now, since the data is just set to the plain JS object,
it's not notified when a change occurs.

Add a subpageItem_ property to extensions page manager so that we can
leverage polymer databinding and link this to the subpages. This way, if
the backing data changes, the open subpage is updated.

Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6635f232a429cdca2c58a3bc5a30bea89f162793
Cr-Commit-Position: refs/heads/master@{#434856}

[Devlin, 2016-11-23 17:26:34]

Description was changed from

==========
[MD Extensions] Update subpages when the backing extension data changes

Many subpages show some form of details for a given extension. When the
backing data changes, those changes need to be reflected in the open
subpage. Right now, since the data is just set to the plain JS object,
it's not notified when a change occurs.

Add a subpageItem_ property to extensions page manager so that we can
leverage polymer databinding and link this to the subpages. This way, if
the backing data changes, the open subpage is updated.

Add a test for the same.

BUG=529395
==========

to

==========
[MD Extensions] Update subpages when the backing extension data changes

Many subpages show some form of details for a given extension. When the
backing data changes, those changes need to be reflected in the open
subpage. Right now, since the data is just set to the plain JS object,
it's not notified when a change occurs.

Add a subpageItem_ property to extensions page manager so that we can
leverage polymer databinding and link this to the subpages. This way, if
the backing data changes, the open subpage is updated.

Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2016-11-23 17:52:37]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 17:53:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:39:35]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-11-23 19:56:53]

rdevlin.cronin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Devlin, 2016-11-23 19:56:53]

Michael, mind taking a look?

[michaelpg, 2016-11-28 23:00:54]

lgtm

https://codereview.chromium.org/2526893002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_manager_test.js (right):

https://codereview.chromium.org/2526893002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_manager_test.js:186:
detailsView.$$('.section .section-content').textContent.trim());
optional: add a different extension item, and verify that
manager.updateItem(otherExtension) does not affect the details view's data

[Devlin, 2016-11-28 23:46:52]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 23:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-11-29 02:14:40]

https://codereview.chromium.org/2526893002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_manager_test.js (right):

https://codereview.chromium.org/2526893002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_manager_test.js:186:
detailsView.$$('.section .section-content').textContent.trim());
On 2016/11/28 23:00:54, michaelpg wrote:
> optional: add a different extension item, and verify that
> manager.updateItem(otherExtension) does not affect the details view's data

Sure, done.

[Devlin, 2016-11-29 02:14:49]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2016-11-29 02:14:56]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-11-29 02:14:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2526893002/#ps40001
(title: "Michael's")

[commit-bot: I haz the power, 2016-11-29 02:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 03:04:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480385696813250,
"parent_rev": "7a2c4c0c73fc7330a11fb74b26a3286bb38a2077", "commit_rev":
"1a80eeec4ae07eb154398412ce87157a207ec650"}

[commit-bot: I haz the power, 2016-11-29 03:04:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 03:08:09]

Description was changed from

==========
[MD Extensions] Update subpages when the backing extension data changes

Many subpages show some form of details for a given extension. When the
backing data changes, those changes need to be reflected in the open
subpage. Right now, since the data is just set to the plain JS object,
it's not notified when a change occurs.

Add a subpageItem_ property to extensions page manager so that we can
leverage polymer databinding and link this to the subpages. This way, if
the backing data changes, the open subpage is updated.

Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions] Update subpages when the backing extension data changes

Many subpages show some form of details for a given extension. When the
backing data changes, those changes need to be reflected in the open
subpage. Right now, since the data is just set to the plain JS object,
it's not notified when a change occurs.

Add a subpageItem_ property to extensions page manager so that we can
leverage polymer databinding and link this to the subpages. This way, if
the backing data changes, the open subpage is updated.

Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6635f232a429cdca2c58a3bc5a30bea89f162793
Cr-Commit-Position: refs/heads/master@{#434856}
==========

[commit-bot: I haz the power, 2016-11-29 03:08:10]

Patchset 3 (id:??) landed as
https://crrev.com/6635f232a429cdca2c58a3bc5a30bea89f162793
Cr-Commit-Position: refs/heads/master@{#434856}