Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2526873002: aw: Fix mStarted assert (Closed)

Created:
4 years ago by boliu
Modified:
4 years ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Fix mStarted assert Move setting mStarted up so getBrowserContextOnUiThread don't hit the assert. BUG=667337 Committed: https://crrev.com/f358617731da18371d313590f6300c15f9615843 Cr-Commit-Position: refs/heads/master@{#434202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
boliu
ptal submit when you approve as well
4 years ago (2016-11-23 17:11:57 UTC) #2
Torne
lgtm
4 years ago (2016-11-23 17:55:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526873002/1
4 years ago (2016-11-23 17:55:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 18:25:15 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-23 18:28:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f358617731da18371d313590f6300c15f9615843
Cr-Commit-Position: refs/heads/master@{#434202}

Powered by Google App Engine
This is Rietveld 408576698