Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2526833003: [ios] Handle gracefully WK messages sent by iframes. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Handle gracefully WK messages sent by iframes. BUG=668227 Committed: https://crrev.com/517eda903af4bedf38b353141b185215dd3ea0d0 Cr-Commit-Position: refs/heads/master@{#434234}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-11-23 19:01:43 UTC) #2
Jackie Quinn
lgtm with wording nit https://codereview.chromium.org/2526833003/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/2526833003/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode2689 ios/web/web_state/ui/crw_web_controller.mm:2689: // Messages from iframes are ...
4 years ago (2016-11-23 19:17:40 UTC) #3
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2526833003/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/2526833003/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode2689 ios/web/web_state/ui/crw_web_controller.mm:2689: // Messages from iframes are not supported yet. ...
4 years ago (2016-11-23 19:28:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526833003/20001
4 years ago (2016-11-23 19:29:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 20:19:52 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-23 20:23:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/517eda903af4bedf38b353141b185215dd3ea0d0
Cr-Commit-Position: refs/heads/master@{#434234}

Powered by Google App Engine
This is Rietveld 408576698