Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252683006: Remove ClosePlatformFile from media galleries. (Closed)

Created:
6 years, 8 months ago by rvargas (doing something else)
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Remove ClosePlatformFile from media galleries. BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266728

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/utility/media_galleries/iapps_xml_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/iapps_xml_utils.cc View 1 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rvargas (doing something else)
PTAL
6 years, 7 months ago (2014-04-28 19:39:44 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/252683006/diff/1/chrome/utility/media_galleries/iapps_xml_utils.cc File chrome/utility/media_galleries/iapps_xml_utils.cc (right): https://codereview.chromium.org/252683006/diff/1/chrome/utility/media_galleries/iapps_xml_utils.cc#newcode89 chrome/utility/media_galleries/iapps_xml_utils.cc:89: if (!file.GetInfo(&file_info) || file_info.size > kMaxLibraryFileSize) nit: only ...
6 years, 7 months ago (2014-04-28 19:47:00 UTC) #2
rvargas (doing something else)
Thanks https://codereview.chromium.org/252683006/diff/1/chrome/utility/media_galleries/iapps_xml_utils.cc File chrome/utility/media_galleries/iapps_xml_utils.cc (right): https://codereview.chromium.org/252683006/diff/1/chrome/utility/media_galleries/iapps_xml_utils.cc#newcode89 chrome/utility/media_galleries/iapps_xml_utils.cc:89: if (!file.GetInfo(&file_info) || file_info.size > kMaxLibraryFileSize) On 2014/04/28 ...
6 years, 7 months ago (2014-04-28 19:53:15 UTC) #3
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-04-28 19:53:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/252683006/20001
6 years, 7 months ago (2014-04-28 19:54:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:24:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 21:24:31 UTC) #7
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 7 months ago (2014-04-28 21:30:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/252683006/20001
6 years, 7 months ago (2014-04-28 21:32:04 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 01:18:34 UTC) #10
Message was sent while issue was closed. 
Change committed as 266728

Powered by Google App Engine
This is Rietveld 408576698