Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2526803002: Reland of [cleanup] CodeStubAssembler: s/compiler::Node/Node/ (Closed)

Created:
4 years ago by Jakob Kummerow
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [cleanup] CodeStubAssembler: s/compiler::Node/Node/ Reducing visual clutter. No changes since previous attempt; this was only reverted because it blocked another revert. Original review: https://codereview.chromium.org/2519093002/ TBR=ishell@chromium.org Committed: https://crrev.com/c28bee0fdd297d2ef4fc88b5fe289cc9dbd664f6 Cr-Commit-Position: refs/heads/master@{#41235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+520 lines, -695 lines) Patch
M src/code-stub-assembler.h View 13 chunks +443 lines, -588 lines 0 comments Download
M src/code-stub-assembler.cc View 34 chunks +77 lines, -107 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Jakob Kummerow
Created Reland of [cleanup] CodeStubAssembler: s/compiler::Node/Node/
4 years ago (2016-11-23 14:42:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526803002/1
4 years ago (2016-11-24 00:01:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 00:04:15 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c28bee0fdd297d2ef4fc88b5fe289cc9dbd664f6 Cr-Commit-Position: refs/heads/master@{#41235}
4 years ago (2016-11-24 00:04:49 UTC) #14
Michael Hablich
4 years ago (2016-11-24 08:39:50 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2529863002/ by hablich@chromium.org.

The reason for reverting is: Needed to revert
https://codereview.chromium.org/2522393002/.

Powered by Google App Engine
This is Rietveld 408576698