content/browser/web_contents/touch_editable_impl_aura_browsertest.cc - Issue 25268002: Make tapDown async.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

Issue 25268002: Make tapDown async. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address jdduke's comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

diff --git a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

index 6c5fa2a1bbf784f8685c6ab3103c3697f5ef91f5..2cc1e9978826172a2d2cabd9802e4666035758e6 100644

--- a/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

+++ b/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

@@ -351,8 +351,7 @@ class TouchEditableImplAuraTest : public ContentBrowserTest {

generator.GestureTapAt(gfx::Point(bounds.x() + 50, bounds.y() + 40));

LOG(INFO) << "Wait for selection to change.";

touch_editable->WaitForSelectionChangeCallback();

- LOG(INFO) << "Wait for tap-down ACK.";

- touch_editable->WaitForGestureAck(); // Wait for Tap Down Ack

+ // No Tap Down Ack is coming, it's async.

touch_editable->Reset();

LOG(INFO) << "Wait for tap ACK.";

touch_editable->WaitForGestureAck(); // Wait for Tap Ack.

« no previous file with comments | « content/browser/renderer_host/overscroll_controller.cc ('k') | no next file » | no next file with comments »