Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: content/browser/renderer_host/input/gesture_event_filter.h

Issue 25268002: Make tapDown async. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address jdduke's comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/gesture_event_filter.h
diff --git a/content/browser/renderer_host/input/gesture_event_filter.h b/content/browser/renderer_host/input/gesture_event_filter.h
index b0c378222eaa1d19ab320500a7c9f62231cd4323..9c3bb7b60dcd7a1d21d2874511af66c139717265 100644
--- a/content/browser/renderer_host/input/gesture_event_filter.h
+++ b/content/browser/renderer_host/input/gesture_event_filter.h
@@ -54,7 +54,7 @@ class GestureEventFilter {
// Indicates that the caller has received an acknowledgement from the renderer
// with state |processed| and event |type|. May send events if the queue is
// not empty.
- void ProcessGestureAck(bool processed, int type);
+ void ProcessGestureAck(bool processed, WebKit::WebInputEvent::Type type);
// Sets the state of the |fling_in_progress_| field to indicate that a fling
// is definitely not in progress.
@@ -77,6 +77,8 @@ class GestureEventFilter {
void ForwardGestureEventSkipDeferral(
const GestureEventWithLatencyInfo& gesture_event);
+ static bool IsGestureEventTypeAsync(WebKit::WebInputEvent::Type type);
+
private:
friend class MockRenderWidgetHost;
friend class ImmediateInputRouterTest;
@@ -146,6 +148,8 @@ class GestureEventFilter {
gfx::Transform GetTransformForEvent(
const GestureEventWithLatencyInfo& gesture_event) const;
+ void SendAsyncEvents();
jdduke (slow) 2013/10/01 17:16:15 Could you put a short note here indicating what t
tdresser 2013/10/01 17:54:36 Done.
+
// The receiver of all forwarded gesture events.
InputRouter* input_router_;
@@ -183,7 +187,12 @@ class GestureEventFilter {
typedef std::deque<GestureEventWithLatencyInfo> GestureEventQueue;
- // Queue of coalesced gesture events not yet sent to the renderer.
+ // Queue of coalesced gesture events not yet sent to the renderer. If
+ // |ignore_next_ack_| is false, then the event at the front of the queue has
+ // been sent and is awaiting an ACK, and all other events have yet to be sent.
+ // If |ignore_next_ack_| is true, then the two events at the front of the
+ // queue have been sent, and the second is awaiting an ACK. All other events
+ // have yet to be sent.
GestureEventQueue coalesced_gesture_events_;
// Tap gesture event currently subject to deferral.

Powered by Google App Engine
This is Rietveld 408576698