Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2526793002: Remove closure_conversion.dart from pkg/kernel. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove closure_conversion.dart from pkg/kernel. This file is not strong-mode clean, but since a more recent version of closure conversion still exists in a branch on the kernel github repo, there is not much point in fixing this version of it. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/5d310431bdb8f8b7041c544d44899ddeb9cb0469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -449 lines) Patch
M pkg/kernel/bin/transform.dart View 3 chunks +3 lines, -9 lines 0 comments Download
D pkg/kernel/lib/transformations/closure_conversion.dart View 1 chunk +0 lines, -440 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
asgerf
4 years ago (2016-11-23 14:26:24 UTC) #4
ahe
lgtm
4 years ago (2016-11-23 14:30:25 UTC) #5
asgerf
4 years ago (2016-11-23 14:34:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d310431bdb8f8b7041c544d44899ddeb9cb0469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698