Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: src/wasm/wasm-module.h

Issue 2526783002: [base] Define CHECK comparison for signed vs. unsigned (Closed)
Patch Set: Extend test case Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 3dc58b8448660831542b9bce58389d3f8428fcba..e02ac9298ec21574cdedd236e3f2d2465526f302 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -230,7 +230,7 @@ struct V8_EXPORT_PRIVATE WasmModule {
WasmName GetName(uint32_t offset, uint32_t length) const {
if (length == 0) return {"<?>", 3}; // no name.
CHECK(BoundsCheck(offset, offset + length));
- DCHECK_GE(static_cast<int>(length), 0);
+ DCHECK_GE(length, 0);
return {reinterpret_cast<const char*>(module_start + offset),
static_cast<int>(length)};
}
@@ -244,7 +244,7 @@ struct V8_EXPORT_PRIVATE WasmModule {
WasmName GetNameOrNull(uint32_t offset, uint32_t length) const {
if (offset == 0 && length == 0) return {NULL, 0}; // no name.
CHECK(BoundsCheck(offset, offset + length));
- DCHECK_GE(static_cast<int>(length), 0);
+ DCHECK_GE(length, 0);
return {reinterpret_cast<const char*>(module_start + offset),
static_cast<int>(length)};
}

Powered by Google App Engine
This is Rietveld 408576698