Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: ios/chrome/browser/net/image_fetcher_unittest.mm

Issue 2526773002: Move iOS ImageFetcher to ios/web/public (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« components/image_fetcher/ios/raw_image_fetcher.mm ('K') | « ios/chrome/browser/net/image_fetcher.mm ('k') | ios/chrome/browser/suggestions/BUILD.gn » ('j') | ios/chrome/browser/suggestions/image_fetcher_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #import "ios/chrome/browser/net/image_fetcher.h"
6
7 #import <UIKit/UIKit.h>
8
9 #include "base/ios/ios_util.h"
10 #include "base/mac/scoped_block.h"
11 #include "base/macros.h"
12 #include "base/memory/ptr_util.h"
13 #include "base/memory/ref_counted.h"
14 #include "base/run_loop.h"
15 #include "base/threading/thread.h"
16 #include "base/threading/thread_task_runner_handle.h"
17 #include "build/build_config.h"
18 #include "net/http/http_response_headers.h"
19 #include "net/url_request/test_url_fetcher_factory.h"
20 #include "net/url_request/url_request_test_util.h"
21 #include "testing/gtest/include/gtest/gtest.h"
22 #include "testing/platform_test.h"
23
24 namespace {
25
26 static unsigned char kJPGImage[] = {
27 255,216,255,224,0,16,74,70,73,70,0,1,1,1,0,72,0,72,0,0,255,254,0,19,67,
28 114,101,97,116,101,100,32,119,105,116,104,32,71,73,77,80,255,219,0,67,
29 0,5,3,4,4,4,3,5,4,4,4,5,5,5,6,7,12,8,7,7,7,7,15,11,11,9,12,17,15,18,18,
30 17,15,17,17,19,22,28,23,19,20,26,21,17,17,24,33,24,26,29,29,31,31,31,
31 19,23,34,36,34,30,36,28,30,31,30,255,219,0,67,1,5,5,5,7,6,7,14,8,8,14,
32 30,20,17,20,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,
33 30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,30,
34 30,30,30,30,30,30,30,30,255,192,0,17,8,0,1,0,1,3,1,34,0,2,17,1,3,17,1,
35 255,196,0,21,0,1,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,8,255,196,0,20,16,1,
36 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,255,196,0,20,1,1,0,0,0,0,0,0,0,0,0,0,
37 0,0,0,0,0,0,255,196,0,20,17,1,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,255,218,
38 0,12,3,1,0,2,17,3,17,0,63,0,178,192,7,255,217
39 };
40
41 static unsigned char kPNGImage[] = {
42 137,80,78,71,13,10,26,10,0,0,0,13,73,72,68,82,0,0,0,1,0,0,0,1,1,0,0,0,
43 0,55,110,249,36,0,0,0,2,98,75,71,68,0,1,221,138,19,164,0,0,0,9,112,72,
44 89,115,0,0,11,18,0,0,11,18,1,210,221,126,252,0,0,0,9,118,112,65,103,0,
45 0,0,1,0,0,0,1,0,199,149,95,237,0,0,0,10,73,68,65,84,8,215,99,104,0,0,
46 0,130,0,129,221,67,106,244,0,0,0,25,116,69,88,116,99,111,109,109,101,
47 110,116,0,67,114,101,97,116,101,100,32,119,105,116,104,32,71,73,77,80,
48 231,175,64,203,0,0,0,37,116,69,88,116,100,97,116,101,58,99,114,101,97,
49 116,101,0,50,48,49,49,45,48,54,45,50,50,84,49,54,58,49,54,58,52,54,43,
50 48,50,58,48,48,31,248,231,223,0,0,0,37,116,69,88,116,100,97,116,101,58,
51 109,111,100,105,102,121,0,50,48,49,49,45,48,54,45,50,50,84,49,54,58,49,
52 54,58,52,54,43,48,50,58,48,48,110,165,95,99,0,0,0,17,116,69,88,116,106,
53 112,101,103,58,99,111,108,111,114,115,112,97,99,101,0,50,44,117,85,159,
54 0,0,0,32,116,69,88,116,106,112,101,103,58,115,97,109,112,108,105,110,
55 103,45,102,97,99,116,111,114,0,50,120,50,44,49,120,49,44,49,120,49,73,
56 250,166,180,0,0,0,0,73,69,78,68,174,66,96,130
57 };
58
59 static unsigned char kWEBPImage[] = {
60 82,73,70,70,74,0,0,0,87,69,66,80,86,80,56,88,10,0,0,0,16,0,0,0,0,0,0,0,0,0,
61 65,76,80,72,12,0,0,0,1,7,16,17,253,15,68,68,255,3,0,0,86,80,56,32,24,0,0,0,
62 48,1,0,157,1,42,1,0,1,0,3,0,52,37,164,0,3,112,0,254,251,253,80,0
63 };
64
65 static const char kTestUrl[] = "http://www.img.com";
66
67 static const char kWEBPHeaderResponse[] =
68 "HTTP/1.1 200 OK\0Content-type: image/webp\0\0";
69
70 } // namespace
71
72 class ImageFetcherTest : public PlatformTest {
73 protected:
74 ImageFetcherTest()
75 : worker_thread_("TestThread"),
76 callback_([^(const GURL& original_url,
77 int http_response_code,
78 NSData * data) {
79 result_ = [UIImage imageWithData:data];
80 called_ = true;
81 } copy]) {
82 worker_thread_.Start();
83
84 image_fetcher_ =
85 base::MakeUnique<ImageFetcher>(worker_thread_.task_runner());
86 image_fetcher_->SetRequestContextGetter(
87 new net::TestURLRequestContextGetter(
88 base::ThreadTaskRunnerHandle::Get()));
89 }
90
91 net::TestURLFetcher* SetupFetcher() {
92 image_fetcher_->StartDownload(GURL(kTestUrl), callback_);
93 EXPECT_EQ(nil, result_);
94 EXPECT_EQ(false, called_);
95 net::TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
96 DCHECK(fetcher);
97 DCHECK(fetcher->delegate());
98 return fetcher;
99 }
100
101 // Message loop for the main test thread.
102 base::MessageLoop loop_;
103
104 // Worker thread used for ImageFetcher's asynchronous work.
105 base::Thread worker_thread_;
106
107 base::mac::ScopedBlock<ImageFetchedCallback> callback_;
108 net::TestURLFetcherFactory factory_;
109 std::unique_ptr<ImageFetcher> image_fetcher_;
110 UIImage* result_ = nil;
111 bool called_ = false;
112
113 private:
114 DISALLOW_COPY_AND_ASSIGN(ImageFetcherTest);
115 };
116
117 TEST_F(ImageFetcherTest, TestError) {
118 net::TestURLFetcher* fetcher = SetupFetcher();
119 fetcher->set_response_code(404);
120 fetcher->delegate()->OnURLFetchComplete(fetcher);
121 EXPECT_EQ(nil, result_);
122 EXPECT_TRUE(called_);
123 }
124
125 TEST_F(ImageFetcherTest, TestJpg) {
126 net::TestURLFetcher* fetcher = SetupFetcher();
127 fetcher->set_response_code(200);
128 fetcher->SetResponseString(std::string((char*)kJPGImage, sizeof(kJPGImage)));
129 fetcher->delegate()->OnURLFetchComplete(fetcher);
130 EXPECT_NE(nil, result_);
131 EXPECT_TRUE(called_);
132 }
133
134 TEST_F(ImageFetcherTest, TestPng) {
135 net::TestURLFetcher* fetcher = SetupFetcher();
136 fetcher->set_response_code(200);
137 fetcher->SetResponseString(std::string((char*)kPNGImage, sizeof(kPNGImage)));
138 fetcher->delegate()->OnURLFetchComplete(fetcher);
139 EXPECT_NE(nil, result_);
140 EXPECT_TRUE(called_);
141 }
142
143 TEST_F(ImageFetcherTest, TestGoodWebP) {
144 // TODO(droger): This test fails on iOS 9 x64 devices. http://crbug.com/523235
145 #if defined(OS_IOS) && defined(ARCH_CPU_ARM64) && !TARGET_IPHONE_SIMULATOR
146 if (base::ios::IsRunningOnIOS9OrLater())
147 return;
148 #endif
149 net::TestURLFetcher* fetcher = SetupFetcher();
150 fetcher->set_response_code(200);
151 fetcher->SetResponseString(
152 std::string((char*)kWEBPImage, sizeof(kWEBPImage)));
153 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
154 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
155 fetcher->set_response_headers(headers);
156 fetcher->delegate()->OnURLFetchComplete(fetcher);
157 worker_thread_.FlushForTesting();
158 base::RunLoop().RunUntilIdle();
159 EXPECT_NE(nil, result_);
160 EXPECT_TRUE(called_);
161 }
162
163 TEST_F(ImageFetcherTest, TestBadWebP) {
164 net::TestURLFetcher* fetcher = SetupFetcher();
165 fetcher->set_response_code(200);
166 fetcher->SetResponseString("This is not a valid WebP image");
167 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
168 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
169 fetcher->set_response_headers(headers);
170 fetcher->delegate()->OnURLFetchComplete(fetcher);
171 worker_thread_.FlushForTesting();
172 base::RunLoop().RunUntilIdle();
173 EXPECT_EQ(nil, result_);
174 EXPECT_TRUE(called_);
175 }
176
177 TEST_F(ImageFetcherTest, DeleteDuringWebPDecoding) {
178 net::TestURLFetcher* fetcher = SetupFetcher();
179 fetcher->set_response_code(200);
180 fetcher->SetResponseString(
181 std::string((char*)kWEBPImage, sizeof(kWEBPImage)));
182 scoped_refptr<net::HttpResponseHeaders> headers(new net::HttpResponseHeaders(
183 std::string(kWEBPHeaderResponse, arraysize(kWEBPHeaderResponse))));
184 fetcher->set_response_headers(headers);
185 fetcher->delegate()->OnURLFetchComplete(fetcher);
186 // Delete the image fetcher, and check that the callback is not called.
187 image_fetcher_.reset();
188 worker_thread_.FlushForTesting();
189 base::RunLoop().RunUntilIdle();
190 EXPECT_EQ(nil, result_);
191 EXPECT_FALSE(called_);
192 }
193
194 TEST_F(ImageFetcherTest, TestCallbacksNotCalledDuringDeletion) {
195 image_fetcher_->StartDownload(GURL(kTestUrl), callback_);
196 image_fetcher_.reset();
197 EXPECT_FALSE(called_);
198 }
199
OLDNEW
« components/image_fetcher/ios/raw_image_fetcher.mm ('K') | « ios/chrome/browser/net/image_fetcher.mm ('k') | ios/chrome/browser/suggestions/BUILD.gn » ('j') | ios/chrome/browser/suggestions/image_fetcher_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698