Move iOS ImageFetcher to ios/web/public

components/image_fetcher/ios/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-source_set("webp_transcode") {
+source_set("ios") {
   sources = [
+    "raw_image_fetcher.h",
+    "raw_image_fetcher.mm",
     "webp_decoder.h",
     "webp_decoder.mm",
   ]
   deps = [
     "//base",
+    "//ios/web",

[sdefresne, 2016/11/23 14:40:33]

I think you can remove this dependency as you do not use anything from //ios/web
(include is stale AFAICT).

[gambard, 2016/11/23 15:01:21]

Done.

+    "//net",
     "//third_party/libwebp:libwebp_dec",
   ]
 }
 
+source_set("test_support") {
+  testonly = true
+  sources = [
+    "mock_raw_image_fetcher.h",
+    "mock_raw_image_fetcher.mm",
+  ]
+  deps = [
+    ":ios",
+    "//testing/gmock",
+  ]
+}
+
 source_set("unit_tests") {
   testonly = true
   sources = [
+    "raw_image_fetcher_unittest.mm",
     "webp_decoder_unittest.mm",
   ]
   deps = [
-    ":webp_transcode",
+    ":ios",
     ":webp_transcode_unit_tests_bundle_data",
     "//base",
+    "//net",
+    "//net:test_support",
     "//testing/gmock",
     "//testing/gtest",
   ]
-  libs = [ "CoreGraphics.framework" ]

[gambard, 2016/11/23 13:56:27]

Do I need this? It seems to be working without it.

[sdefresne, 2016/11/23 14:40:33]

Yes, you need it because webp_decoder_unittest.mm import
CoreGraphics/CoreGraphics.h and uses some of the code from the framework. It
appears to work because this is only required for linking the final application
(it add "-framework CoreGraphics" on the linker command-line) and if any other
target list this framework in its libs then the linker will be happy (since it
only cares about seeing the argument once).

It is better to list it because it makes the target easier to re-use
independently of any other.

[gambard, 2016/11/23 15:01:21]

Thanks!
Done.

 }
 
 bundle_data("webp_transcode_unit_tests_bundle_data") {
   visibility = [ ":unit_tests" ]
   testonly = true
   sources = [
-    "//ios/chrome/test/data/webp_transcode/test.jpg",
-    "//ios/chrome/test/data/webp_transcode/test.webp",
-    "//ios/chrome/test/data/webp_transcode/test_alpha.png",
-    "//ios/chrome/test/data/webp_transcode/test_alpha.webp",
-    "//ios/chrome/test/data/webp_transcode/test_small.tiff",
-    "//ios/chrome/test/data/webp_transcode/test_small.webp",
+    "//components/test/data/webp_transcode/test.jpg",
+    "//components/test/data/webp_transcode/test.webp",
+    "//components/test/data/webp_transcode/test_alpha.png",
+    "//components/test/data/webp_transcode/test_alpha.webp",
+    "//components/test/data/webp_transcode/test_small.tiff",
+    "//components/test/data/webp_transcode/test_small.webp",
   ]
   outputs = [
     "{{bundle_resources_dir}}/{{source_root_relative_dir}}/" +
         "{{source_file_part}}",
   ]
 }