Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2526753002:
Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials (Closed)
|
Created:
4 years ago by Marc Treib Modified:
4 years ago Reviewers:
Jered CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInstant cleanup: Remove abandoned EmbeddedSearch Android-only field trials
This removes the prefetch_results and reuse_instant_search_base_page parameters.
BUG=627483
Committed: https://crrev.com/683745f53c0f2709e22c6305d97bf72fa5dc16ab
Cr-Commit-Position: refs/heads/master@{#434997}
Patch Set 1 #
Total comments: 4
Patch Set 2 : review #
Messages
Total messages: 23 (16 generated)
Description was changed from ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials BUG=627747 ========== to ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials BUG=627483 ==========
Description was changed from ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials BUG=627483 ========== to ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials This removes the prefetch_results and reuse_instant_search_base_page parameters. BUG=627483 ==========
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
treib@chromium.org changed reviewers: + jered@chromium.org
PTAL!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/23 11:05:26, Marc Treib wrote: > PTAL! Ping!
lgtm https://codereview.chromium.org/2526753002/diff/1/components/search/search.cc File components/search/search.cc (right): https://codereview.chromium.org/2526753002/diff/1/components/search/search.cc... components/search/search.cc:57: #endif // defined(OS_IOS) nit: please update or remove this comment. https://codereview.chromium.org/2526753002/diff/1/components/search/search.cc... components/search/search.cc:154: return ShouldPrefetchSearchResults(); nit: It might be simpler to also have this return IsInstantExtendedAPIEnabled.
https://codereview.chromium.org/2526753002/diff/1/components/search/search.cc File components/search/search.cc (right): https://codereview.chromium.org/2526753002/diff/1/components/search/search.cc... components/search/search.cc:57: #endif // defined(OS_IOS) On 2016/11/28 23:47:48, Jered wrote: > nit: please update or remove this comment. Done. https://codereview.chromium.org/2526753002/diff/1/components/search/search.cc... components/search/search.cc:154: return ShouldPrefetchSearchResults(); On 2016/11/28 23:47:48, Jered wrote: > nit: It might be simpler to also have this return IsInstantExtendedAPIEnabled. Done. (It'd probably make sense to merge all these functions into one, but that's for another day.)
The CQ bit was checked by treib@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by treib@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jered@chromium.org Link to the patchset: https://codereview.chromium.org/2526753002/#ps20001 (title: "review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480433146779170,
"parent_rev": "aaba4630efb8d7f4e403f5c10e2bf1db13c72e5c", "commit_rev":
"d0c562eb4dd8258736e541882a916469458627e9"}
Message was sent while issue was closed.
Description was changed from ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials This removes the prefetch_results and reuse_instant_search_base_page parameters. BUG=627483 ========== to ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials This removes the prefetch_results and reuse_instant_search_base_page parameters. BUG=627483 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials This removes the prefetch_results and reuse_instant_search_base_page parameters. BUG=627483 ========== to ========== Instant cleanup: Remove abandoned EmbeddedSearch Android-only field trials This removes the prefetch_results and reuse_instant_search_base_page parameters. BUG=627483 Committed: https://crrev.com/683745f53c0f2709e22c6305d97bf72fa5dc16ab Cr-Commit-Position: refs/heads/master@{#434997} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/683745f53c0f2709e22c6305d97bf72fa5dc16ab Cr-Commit-Position: refs/heads/master@{#434997} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
