Fixed screen capture confirmation dialog to be either system or browser window modal.

Fixed screen capture confirmation dialog to be either system- or window-modal depending on where it got initiated from. Previous implementation created window-modal with no parent window which allowed it to hide underneath its browser window.

Fixed handling of window-modal dialogs. Modal dialogs and their toplevel parent windows weren't properly activated on events (i.e. mouse click) that happen in toplevel parent windows area but outside of the modal dialog.

TEST=added WindowModalityControllerTest.EventsForEclipsedWindows, manual: start go/present/<whatever>, try to alt-tab away from the pop up dialog, try to eclipse it with another browser window
BUG=366956
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266319

[Jun Mukai, 2014-04-25 01:42:42]

lgtm

[sky, 2014-04-25 15:41:03]

LGTM

[zel, 2014-04-25 17:55:37]

PTAL

I needed also to fix i/wm/core/window_modality_controller.cc since window-modal
dialogs and its top-level window weren't properly shown if you mouse click on
the top-level window area but not on the dialog itself. In this case, if the
modal dialog was eclipsed by another window, you can never actually get it in
foreground.

[oshima, 2014-04-25 19:06:06]

https://codereview.chromium.org/252673002/diff/60001/ui/wm/core/window_modali...
File ui/wm/core/window_modality_controller.cc (right):

https://codereview.chromium.org/252673002/diff/60001/ui/wm/core/window_modali...
ui/wm/core/window_modality_controller.cc:189: aura::Window* toplevel =
GetToplevelWindow(target);
shouldn't this be modal_transient_child?

[zel, 2014-04-25 20:44:40]

i've added a unit test for this too

https://codereview.chromium.org/252673002/diff/60001/ui/wm/core/window_modali...
File ui/wm/core/window_modality_controller.cc (right):

https://codereview.chromium.org/252673002/diff/60001/ui/wm/core/window_modali...
ui/wm/core/window_modality_controller.cc:189: aura::Window* toplevel =
GetToplevelWindow(target);
On 2014/04/25 19:06:06, oshima wrote:
> shouldn't this be modal_transient_child?

it makes no difference since it boils down to the same object except that this
path requires less window tree traveling when top window is actually |target|

[sky, 2014-04-25 21:05:47]

LGTM

[zel, 2014-04-25 21:15:25]

The CQ bit was checked by zelidrag@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:01:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/252673002/100001

[commit-bot: I haz the power, 2014-04-26 02:10:39]

Change committed as 266319