Specify the WebAPK server URL in Chromium source code

chrome/browser/android/webapk/webapk_installer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include "base/android/build_info.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/path_utils.h"
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task_runner_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "chrome/browser/android/chrome_feature_list.h"

[Xi Han, 2016/11/24 14:27:50]

Do you still need this include?

 #include "chrome/browser/android/shortcut_helper.h"
 #include "chrome/browser/android/webapk/webapk.pb.h"
 #include "chrome/browser/android/webapk/webapk_icon_hasher.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_switches.h"
 #include "components/variations/variations_associated_data.h"

[Xi Han, 2016/11/24 14:27:50]

Do you still need this include? I see you removed it in the unit tests, and some
more. Please clean up here if I missed anything:)

 #include "components/version_info/version_info.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/manifest_util.h"
 #include "jni/WebApkInstaller_jni.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_fetcher.h"
 #include "ui/gfx/codec/png_codec.h"
 #include "url/gurl.h"
 
 namespace {
 
 // The default WebAPK server URL.
 const char kDefaultServerUrl[] =
-    "https://webapk.googleapis.com/v1alpha/webApks/?alt=proto";
-
-// Flag for setting the WebAPK server URL.
-const char kServerUrlVariationsParamKey[] = "ServerUrl";
+    "https://test-webapk.sandbox.googleapis.com/v1/webApks/?alt=proto&key=AIzaSyAoI6v-F31-3t9NunLYEiKcPIqgTJIUZBw";

[Xi Han, 2016/11/24 14:27:50]

Is the test server public? I am wondering whether is it secure to put this URL
public? Maybe wait until the prod server is public and add that URL directly?

[pkotwicz, 2016/11/25 01:29:19]

A user can currently figure out what the URL is using Charles proxy or Wireshark

 
 // The MIME type of the POST data sent to the server.
 const char kProtoMimeType[] = "application/x-protobuf";
 
 // The default number of milliseconds to wait for the WebAPK download URL from
 // the WebAPK server.
 const int kWebApkDownloadUrlTimeoutMs = 60000;
 
 // The default number of milliseconds to wait for the WebAPK download to
 // complete.
 const int kDownloadTimeoutMs = 60000;
 
 const int kWorldReadableFilePermission = base::FILE_PERMISSION_READ_BY_USER |
                                          base::FILE_PERMISSION_READ_BY_GROUP |
                                          base::FILE_PERMISSION_READ_BY_OTHERS;
 
-// Returns the WebAPK server URL based on the command line flags and the
-// currently active field trials.
+// Returns the WebAPK server URL based on the command line.
 GURL GetServerUrl() {
-  GURL server_url(variations::GetVariationParamValueByFeature(
-      chrome::android::kWebApks, kServerUrlVariationsParamKey));
-  return server_url.is_valid() ? server_url : GURL(kDefaultServerUrl);
+  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+  std::string url_string =
+      command_line->HasSwitch(switches::kWebApkServerUrl)
+          ? command_line->GetSwitchValueASCII(switches::kWebApkServerUrl)
+          : kDefaultServerUrl;
+  return GURL(url_string);
 }
 
 // Returns the scope from |info| if it is specified. Otherwise, returns the
 // default scope.
 GURL GetScope(const ShortcutInfo& info) {
   return (info.scope.is_valid())
       ? info.scope
       : ShortcutHelper::GetScopeFromURL(info.url);
 }
 
@@ skipping 442 matching lines @@
 
 void WebApkInstaller::OnSuccess() {
   finish_callback_.Run(true, webapk_package_);
   delete this;
 }
 
 void WebApkInstaller::OnFailure() {
   finish_callback_.Run(false, webapk_package_);
   delete this;
 }