[Android] Fix a bug where the suggestion list can't scroll

[Android] Fix a bug where the suggestion list can't scroll

After we placed omnibox suggestion list as a child of
CompositorViewHolder, it no longer is able to scroll.

The investigation of this regression gave interesting result: if an
ACTION_MOVE is dispatched to a ListView or a ScrollView and the
ViewGroup intercepts it, the framework will generate an ACTION_CANCEL to
the ViewGroup's children. The behavior, however, will steal this cancel
event and send to the ViewGroup again, causing scroll to fail. Thus we
should specifically not catch ACTION_CANCEL in behavior.

BUG=648136
Committed: https://crrev.com/54b3389c1b9f0baf10fedd3bb78c85091a4e49b7
Cr-Commit-Position: refs/heads/master@{#434761}

[Ian Wen, 2016-11-24 00:45:31]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ian Wen, 2016-11-24 00:45:31]

PTAL

[Ian Wen, 2016-11-24 00:46:17]

ianwen@chromium.org changed reviewers:
+ mdjones@chromium.org

[mdjones, 2016-11-28 16:24:50]

https://codereview.chromium.org/2526673004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderBehavior.java
(right):

https://codereview.chromium.org/2526673004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolderBehavior.java:47:
if (!mShouldIntercept || ev.getActionMasked() == MotionEvent.ACTION_CANCEL)
return false;
Does this break event streams that need a cancel event? Does it make sense to
dispatch this event and return false?

[Ian Wen, 2016-11-28 19:31:58]

PTAL. I updated the comments in code.

This patch potentially will cause the parent ViewGroup of snackbars and
suggestion list to scroll in a wonky way. Yet currently they don't scroll.

[mdjones, 2016-11-28 21:09:04]

lgtm

[Ian Wen, 2016-11-28 21:12:34]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:13:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:58:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480367554629520,
"parent_rev": "07803b3f578498588bdfe83aae18425170ecd7be", "commit_rev":
"9cc1aaa415a332b4bc248a9839e3a97d6e867675"}

[commit-bot: I haz the power, 2016-11-28 22:58:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 23:00:56]

Description was changed from

==========
[Android] Fix a bug where the suggestion list can't scroll

After we placed omnibox suggestion list as a child of
CompositorViewHolder, it no longer is able to scroll.

The investigation of this regression gave interesting result: if an
ACTION_MOVE is dispatched to a ListView or a ScrollView and the
ViewGroup intercepts it, the framework will generate an ACTION_CANCEL to
the ViewGroup's children. The behavior, however, will steal this cancel
event and send to the ViewGroup again, causing scroll to fail. Thus we
should specifically not catch ACTION_CANCEL in behavior.

BUG=648136
==========

to

==========
[Android] Fix a bug where the suggestion list can't scroll

After we placed omnibox suggestion list as a child of
CompositorViewHolder, it no longer is able to scroll.

The investigation of this regression gave interesting result: if an
ACTION_MOVE is dispatched to a ListView or a ScrollView and the
ViewGroup intercepts it, the framework will generate an ACTION_CANCEL to
the ViewGroup's children. The behavior, however, will steal this cancel
event and send to the ViewGroup again, causing scroll to fail. Thus we
should specifically not catch ACTION_CANCEL in behavior.

BUG=648136

Committed: https://crrev.com/54b3389c1b9f0baf10fedd3bb78c85091a4e49b7
Cr-Commit-Position: refs/heads/master@{#434761}
==========

[commit-bot: I haz the power, 2016-11-28 23:00:57]

Patchset 2 (id:??) landed as
https://crrev.com/54b3389c1b9f0baf10fedd3bb78c85091a4e49b7
Cr-Commit-Position: refs/heads/master@{#434761}