Issue 2526653002: [Cronet] Update test recv byte count after crrev.com/434032

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2526653002: [Cronet] Update test recv byte count after crrev.com/434032 (Closed)

Created:
4 years ago by pauljensen

Modified:
4 years ago

Reviewers:
mgersh

CC:
chromium-reviews, cbentzel+watch_chromium.org, yhirano

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Cronet] Update test recv byte count after crrev.com/434032 UrlRequestFailedJob now accounts for header size. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pauljensen

4 years ago (2016-11-23 01:56:14 UTC) #5

On 2016/11/23 01:40:22, pauljensen wrote:
> Miriam, PTAL, this is breaking lots of Cronet bots.

Forget it, the other change was reverted.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages