tracing/tracing/metrics/v8/v8_metrics.html - Issue 2526613002: Return short-hand object literals to exportTo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/metrics/v8/v8_metrics.html

Issue 2526613002: Return short-hand object literals to exportTo. (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2016 The Chromium Authors. All rights reserved.	3 Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="import" href="/tracing/metrics/metric_registry.html">	8 <link rel="import" href="/tracing/metrics/metric_registry.html">

9 <link rel="import" href="/tracing/metrics/system_health/memory_metric.html">	9 <link rel="import" href="/tracing/metrics/system_health/memory_metric.html">

10 <link rel="import" href="/tracing/metrics/v8/execution_metric.html">	10 <link rel="import" href="/tracing/metrics/v8/execution_metric.html">

11 <link rel="import" href="/tracing/metrics/v8/gc_metric.html">	11 <link rel="import" href="/tracing/metrics/v8/gc_metric.html">

12	12

13 <script>	13 <script>

14 'use strict';	14 'use strict';

15	15

16 tr.exportTo('tr.metrics.v8', function() {	16 tr.exportTo('tr.metrics.v8', function() {

17 function v8AndMemoryMetrics(values, model) {	17 function v8AndMemoryMetrics(values, model) {

18 tr.metrics.v8.executionMetric(values, model);	18 tr.metrics.v8.executionMetric(values, model);

19 tr.metrics.v8.gcMetric(values, model);	19 tr.metrics.v8.gcMetric(values, model);

20 tr.metrics.sh.memoryMetric(values, model,	20 tr.metrics.sh.memoryMetric(values, model,

21 {rangeOfInterest: tr.metrics.v8.utils.rangeForMemoryDumps(model)});	21 {rangeOfInterest: tr.metrics.v8.utils.rangeForMemoryDumps(model)});

22 }	22 }

23	23

24 tr.metrics.MetricRegistry.register(v8AndMemoryMetrics);	24 tr.metrics.MetricRegistry.register(v8AndMemoryMetrics);

25	25

26 return {	26 return {

27 v8AndMemoryMetrics: v8AndMemoryMetrics	27 v8AndMemoryMetrics,

28 };	28 };

29 });	29 });

30 </script>	30 </script>

OLD	NEW

« no previous file with comments | « tracing/tracing/metrics/v8/utils.html ('k') | tracing/tracing/model/activity.html » ('j') | tracing/tracing/ui/base/draw_helpers.html » ('J')