Return short-hand object literals to exportTo.

Return short-hand object literals to exportTo.

Currently, HTML source files in tracing/ manage namespaces using tr.exportTo(),
which takes a namespace string and a callback that returns a dictionary.
exportTo adds the returned dictionary to the namespace specified by the
namespace string.
The dictionaries returned to exportTo are currently in ES5 long-form like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i $f;done

This is git blame churn, but only in content-free source lines.

BUG=catapult:#2963

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/476d031f85fa622d1688ba2e3c08b2a5bb8d437a

[benjhayden, 2016-11-22 22:31:28]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-11-22 22:31:42]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-11-22 22:31:43]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-11-22 22:31:44]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-11-22 22:31:51]

Patchset #2 (id:20001) has been deleted

[benjhayden, 2016-11-22 22:31:51]

Patchset #2 (id:20001) has been deleted

[benjhayden, 2016-11-22 22:31:52]

Patchset #2 (id:20001) has been deleted

[benjhayden, 2016-11-22 22:31:52]

Patchset #2 (id:20001) has been deleted

[benjhayden, 2016-11-22 22:31:58]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-11-22 22:32:00]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-11-22 22:34:19]

Description was changed from

==========
Make charts compute their own margins.

Each chart contains a graph area plus margins around it for axes, labels, and a
legend, all contained in an svg tag.
Currently, charts require callers to specify the width/height of the total svg
tag
as well as the margins within. Charts compute the width/height of the graph
area.

However, callers generally do not have the tools necessary to calculate correct
values for the margins. Callers know what data they want to display, not how big
margins will need to be in order to contain axes, labels, and the legend.

This CL makes callers specify the width/height of the graph area, and makes
charts calculate the margins from the data.

BUG=catapult:#2958
==========

to

==========
Return short-hand object literals to exportTo.

Currently, tracing HTML source files manage namespacing using tr.exportTo, which
takes a 

BUG=catapult:#2963
==========

[benjhayden, 2016-11-22 22:43:32]

Description was changed from

==========
Return short-hand object literals to exportTo.

Currently, tracing HTML source files manage namespacing using tr.exportTo, which
takes a 

BUG=catapult:#2963
==========

to

==========
Return short-hand object literals to exportTo.

Currently, tracing HTML source files manage namespacing using tr.exportTo, which
takes a namespace string and a callback that returns a dictionary. exportTo adds
the returned dictionary to the namespace specified by the namespace string.
The dictionaries that sources return to exportTo are currently in ES5 long-form
like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace
errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i
$f;done

BUG=catapult:#2963
==========

[benjhayden, 2016-11-22 22:44:25]

Description was changed from

==========
Return short-hand object literals to exportTo.

Currently, tracing HTML source files manage namespacing using tr.exportTo, which
takes a namespace string and a callback that returns a dictionary. exportTo adds
the returned dictionary to the namespace specified by the namespace string.
The dictionaries that sources return to exportTo are currently in ES5 long-form
like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace
errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i
$f;done

BUG=catapult:#2963
==========

to

==========
Return short-hand object literals to exportTo.

Currently, tracing HTML source files manage namespacing using tr.exportTo, which
takes a namespace string and a callback that returns a dictionary. exportTo adds
the returned dictionary to the namespace specified by the namespace string.
The dictionaries that sources return to exportTo are currently in ES5 long-form
like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace
errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i
$f;done

This is git blame churn, but only in content-free source lines.

BUG=catapult:#2963
==========

[benjhayden, 2016-11-22 23:20:45]

Description was changed from

==========
Return short-hand object literals to exportTo.

Currently, tracing HTML source files manage namespacing using tr.exportTo, which
takes a namespace string and a callback that returns a dictionary. exportTo adds
the returned dictionary to the namespace specified by the namespace string.
The dictionaries that sources return to exportTo are currently in ES5 long-form
like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace
errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i
$f;done

This is git blame churn, but only in content-free source lines.

BUG=catapult:#2963
==========

to

==========
Return short-hand object literals to exportTo.

Currently, HTML source files in tracing/ manage namespaces using tr.exportTo(),
which takes a namespace string and a callback that returns a dictionary.
exportTo adds the returned dictionary to the namespace specified by the
namespace string.
The dictionaries returned to exportTo are currently in ES5 long-form like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace
errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i
$f;done

This is git blame churn, but only in content-free source lines.

BUG=catapult:#2963
==========

[benjhayden, 2016-11-22 23:21:23]

benjhayden@chromium.org changed reviewers:
+ charliea@chromium.org

[benjhayden, 2016-11-22 23:21:26]

PTAL :-)

https://codereview.chromium.org/2526613002/diff/40001/tracing/tracing/ui/base...
File tracing/tracing/ui/base/draw_helpers.html (right):

https://codereview.chromium.org/2526613002/diff/40001/tracing/tracing/ui/base...
tracing/tracing/ui/base/draw_helpers.html:414: elidedTitleCache_:
elidedTitleCache,
This smells funny.
This is only used in rect_track_test.
Maybe rect_track_test could use its own ElidedTitleCache instance?

[benjhayden, 2016-11-22 23:21:52]

On 2016/11/22 at 23:21:26, benjhayden wrote:
> PTAL :-)
> 
>
https://codereview.chromium.org/2526613002/diff/40001/tracing/tracing/ui/base...
> File tracing/tracing/ui/base/draw_helpers.html (right):
> 
>
https://codereview.chromium.org/2526613002/diff/40001/tracing/tracing/ui/base...
> tracing/tracing/ui/base/draw_helpers.html:414: elidedTitleCache_:
elidedTitleCache,
> This smells funny.
> This is only used in rect_track_test.
> Maybe rect_track_test could use its own ElidedTitleCache instance?

Sorry, nevermind about elidedTitleCache_. :-)

[benjhayden, 2016-11-23 00:28:28]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org
- charliea@chromium.org

[benjhayden, 2016-11-23 00:28:29]

Looks like charliea is out for the week.
eakuefner PTAL? :-)

[eakuefner, 2016-11-23 16:16:43]

lgtm

[benjhayden, 2016-11-23 16:43:13]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2016-11-23 16:43:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 17:07:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479919393452190,
"parent_rev": "99ee6566b20f3d49f63d12e1ab70cfd81b017293", "commit_rev":
"476d031f85fa622d1688ba2e3c08b2a5bb8d437a"}

[commit-bot: I haz the power, 2016-11-23 17:07:11]

Description was changed from

==========
Return short-hand object literals to exportTo.

Currently, HTML source files in tracing/ manage namespaces using tr.exportTo(),
which takes a namespace string and a callback that returns a dictionary.
exportTo adds the returned dictionary to the namespace specified by the
namespace string.
The dictionaries returned to exportTo are currently in ES5 long-form like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace
errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i
$f;done

This is git blame churn, but only in content-free source lines.

BUG=catapult:#2963
==========

to

==========
Return short-hand object literals to exportTo.

Currently, HTML source files in tracing/ manage namespaces using tr.exportTo(),
which takes a namespace string and a callback that returns a dictionary.
exportTo adds the returned dictionary to the namespace specified by the
namespace string.
The dictionaries returned to exportTo are currently in ES5 long-form like
{foo: foo}.
However, this long-form is repetitive and prone to copy-paste/find-replace
errors.

This CL uses sed to convert these long-form dictionaries to ES6 short-hand like
{foo}.

for f in *.html;do sed -e 's/^    \([_a-zA-Z0-9]\+\): \1,\?$/    \1,/g' -i
$f;done

This is git blame churn, but only in content-free source lines.

BUG=catapult:#2963

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-11-23 17:07:12]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...