Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: lib/Values_h.template

Issue 2526603002: [inspector_protocol] Introduce protocol::Serializable (Closed)
Patch Set: minor fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/Values_cpp.template ('k') | templates/Imported_h.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Values_h.template
diff --git a/lib/Values_h.template b/lib/Values_h.template
index 8e0d555d213998bd9642d96158b925b0062320a0..646543af0bc85989135fafbccbd0dcce836f9b0e 100644
--- a/lib/Values_h.template
+++ b/lib/Values_h.template
@@ -17,10 +17,10 @@ class ListValue;
class DictionaryValue;
class Value;
-class {{config.lib.export_macro}} Value {
+class {{config.lib.export_macro}} Value : public Serializable {
PROTOCOL_DISALLOW_COPY(Value);
public:
- virtual ~Value() { }
+ virtual ~Value() override { }
static std::unique_ptr<Value> null()
{
@@ -48,9 +48,9 @@ public:
virtual bool asString(String* output) const;
virtual bool asSerialized(String* output) const;
- String toJSONString() const;
virtual void writeJSON(StringBuilder* output) const;
virtual std::unique_ptr<Value> clone() const;
+ String serialize() override;
protected:
Value() : m_type(TypeNull) { }
« no previous file with comments | « lib/Values_cpp.template ('k') | templates/Imported_h.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698