WPR recording update for amazon - key_mobile_sites

WPR recording update for amazon - key_mobile_sites

BUG=667432

[tdresser, 2016-11-22 20:59:29]

tdresser@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2016-11-22 21:04:01]

lgtm

[tdresser, 2016-11-22 21:58:57]

On 2016/11/22 21:04:01, nednguyen wrote:
> lgtm

Just confirming - when rerecording that amazon page, I can just use
--browser=system, right?

[sullivan, 2016-11-22 22:12:33]

On 2016/11/22 21:58:57, tdresser wrote:
> On 2016/11/22 21:04:01, nednguyen wrote:
> > lgtm
> 
> Just confirming - when rerecording that amazon page, I can just use
> --browser=system, right?

I think you need to sync past https://codereview.chromium.org/2446433003 which
does an automatic redirect to https. See
https://bugs.chromium.org/p/chromium/issues/detail?id=667432#c7

[nednguyen, 2016-11-23 11:20:34]

On 2016/11/22 22:12:33, sullivan wrote:
> On 2016/11/22 21:58:57, tdresser wrote:
> > On 2016/11/22 21:04:01, nednguyen wrote:
> > > lgtm
> > 
> > Just confirming - when rerecording that amazon page, I can just use
> > --browser=system, right?
> 
> I think you need to sync past https://codereview.chromium.org/2446433003 which
> does an automatic redirect to https. See
> https://bugs.chromium.org/p/chromium/issues/detail?id=667432#c7

Or you can just update the URL to https

[tdresser, 2016-11-23 13:47:08]

tdresser@chromium.org changed reviewers:
+ sullivan@chromium.org

[tdresser, 2016-11-23 13:47:08]

Done (manually updated the URL).

[nednguyen, 2016-11-23 14:19:40]

https://codereview.chromium.org/2526583002/diff/20001/tools/perf/page_sets/da...
File tools/perf/page_sets/data/key_mobile_sites_011.wpr.sha1 (right):

https://codereview.chromium.org/2526583002/diff/20001/tools/perf/page_sets/da...
tools/perf/page_sets/data/key_mobile_sites_011.wpr.sha1:1:
cdbc458b967dc12ac10173a74cbacd521b4a0387
Remove this file?

[tdresser, 2016-11-23 14:25:06]

Whoops, done.

[nednguyen, 2016-11-23 14:34:00]

How did you produce these WPR archive mapping file? Didn't you modify the url in
the corresponding page sets to the https version? 

https://cs.chromium.org/chromium/src/tools/perf/page_sets/key_mobile_sites_pa...

https://cs.chromium.org/chromium/src/tools/perf/page_sets/key_mobile_sites_sm...

https://codereview.chromium.org/2526583002/diff/40001/tools/perf/page_sets/da...
File tools/perf/page_sets/data/key_mobile_sites_smooth.json (right):

https://codereview.chromium.org/2526583002/diff/40001/tools/perf/page_sets/da...
tools/perf/page_sets/data/key_mobile_sites_smooth.json:74:
"key_mobile_sites_011.wpr": [
Hmhh, I was wrong. Seems like this needs to use the key_mobile_sites_011.wpr
version

[tdresser, 2016-11-23 15:00:45]

Whoops, looks like there were some accidental changes there.

I've cleaned this up.

[nednguyen, 2016-11-23 16:45:24]

lgtm

[tdresser, 2016-11-23 16:46:21]

The CQ bit was checked by tdresser@chromium.org

[nednguyen, 2016-11-23 16:46:51]

On 2016/11/23 16:45:24, nednguyen wrote:
> lgtm

Actually, key_mobile_sites_smooth recording will also need to be updated because
they are currently pointing to http version of amazon (through code share)

[commit-bot: I haz the power, 2016-11-23 16:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-11-23 16:47:08]

The CQ bit was unchecked by nednguyen@google.com

[tdresser, 2016-11-28 15:12:19]

Description was changed from

==========
WPR recording update for amazon - key_mobile_sites

BUG=667432
==========

to

==========
WPR recording update for amazon - key_mobile_sites

BUG=667432
==========