Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2526583002: WPR recording update for amazon - key_mobile_sites (Closed)

Created:
4 years, 1 month ago by tdresser
Modified:
4 years ago
Reviewers:
nednguyen, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WPR recording update for amazon - key_mobile_sites BUG=667432

Patch Set 1 #

Patch Set 2 : Switch to https #

Total comments: 1

Patch Set 3 : remove old sha #

Total comments: 1

Patch Set 4 : Clean up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -61 lines) Patch
M tools/perf/page_sets/data/key_mobile_sites.json View 1 2 3 1 chunk +62 lines, -59 lines 0 comments Download
M tools/perf/page_sets/data/key_mobile_sites_009.wpr.sha1 View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/page_sets/key_mobile_sites_pages.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (5 generated)
tdresser
4 years, 1 month ago (2016-11-22 20:59:30 UTC) #2
nednguyen
lgtm
4 years, 1 month ago (2016-11-22 21:04:01 UTC) #3
tdresser
On 2016/11/22 21:04:01, nednguyen wrote: > lgtm Just confirming - when rerecording that amazon page, ...
4 years, 1 month ago (2016-11-22 21:58:57 UTC) #4
sullivan
On 2016/11/22 21:58:57, tdresser wrote: > On 2016/11/22 21:04:01, nednguyen wrote: > > lgtm > ...
4 years, 1 month ago (2016-11-22 22:12:33 UTC) #5
nednguyen
On 2016/11/22 22:12:33, sullivan wrote: > On 2016/11/22 21:58:57, tdresser wrote: > > On 2016/11/22 ...
4 years ago (2016-11-23 11:20:34 UTC) #6
tdresser
Done (manually updated the URL).
4 years ago (2016-11-23 13:47:08 UTC) #8
nednguyen
https://codereview.chromium.org/2526583002/diff/20001/tools/perf/page_sets/data/key_mobile_sites_011.wpr.sha1 File tools/perf/page_sets/data/key_mobile_sites_011.wpr.sha1 (right): https://codereview.chromium.org/2526583002/diff/20001/tools/perf/page_sets/data/key_mobile_sites_011.wpr.sha1#newcode1 tools/perf/page_sets/data/key_mobile_sites_011.wpr.sha1:1: cdbc458b967dc12ac10173a74cbacd521b4a0387 Remove this file?
4 years ago (2016-11-23 14:19:40 UTC) #9
tdresser
Whoops, done.
4 years ago (2016-11-23 14:25:06 UTC) #10
nednguyen
How did you produce these WPR archive mapping file? Didn't you modify the url in ...
4 years ago (2016-11-23 14:34:00 UTC) #11
tdresser
Whoops, looks like there were some accidental changes there. I've cleaned this up.
4 years ago (2016-11-23 15:00:45 UTC) #12
nednguyen
lgtm
4 years ago (2016-11-23 16:45:24 UTC) #13
nednguyen
On 2016/11/23 16:45:24, nednguyen wrote: > lgtm Actually, key_mobile_sites_smooth recording will also need to be ...
4 years ago (2016-11-23 16:46:51 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-23 16:46:53 UTC) #16

Powered by Google App Engine
This is Rietveld 408576698