Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2526563003: Update the build instructions to be consistent. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, Mike Lawther (Google), sashab, groby-ooo-7-16
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the build instructions to be consistent. We have lots of inconsistencies between the different platforms in the public instructions, and between the public instructions and the internal instructions. This CL (along with an internal one) should clean everything up. TBR=teresam@google.com, sdy@chromium.org NOTRY=true Committed: https://crrev.com/0ae7cad40abf0a6ec7e9ebe8929c81ab979d64e4 Cr-Commit-Position: refs/heads/master@{#435138}

Patch Set 1 #

Patch Set 2 : update windows build instructions #

Patch Set 3 : update ios, win instructions #

Patch Set 4 : more updates #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+691 lines, -699 lines) Patch
M docs/android_build_instructions.md View 1 2 3 3 chunks +99 lines, -75 lines 0 comments Download
D docs/cast_build_instructions.md View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
D docs/chromeos_build_instructions.md View 1 2 3 1 chunk +0 lines, -88 lines 0 comments Download
D docs/chromoting_build_instructions.md View 1 2 3 1 chunk +0 lines, -131 lines 0 comments Download
A docs/get_the_code.md View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download
M docs/ios_build_instructions.md View 1 2 3 2 chunks +127 lines, -57 lines 0 comments Download
A docs/linux_arch_build_instructions.md View 1 chunk +20 lines, -0 lines 0 comments Download
M docs/linux_build_instructions.md View 1 2 3 2 chunks +126 lines, -93 lines 0 comments Download
A docs/linux_debian_build_instructions.md View 1 chunk +12 lines, -0 lines 0 comments Download
A docs/linux_fedora_build_instructions.md View 1 chunk +25 lines, -0 lines 0 comments Download
A docs/linux_mandriva_build_instructions.md View 1 chunk +20 lines, -0 lines 0 comments Download
M docs/linux_open_suse_build_instructions.md View 2 chunks +4 lines, -11 lines 0 comments Download
M docs/mac_build_instructions.md View 1 2 3 6 chunks +82 lines, -61 lines 1 comment Download
D docs/ninja_build.md View 1 chunk +0 lines, -102 lines 0 comments Download
A + docs/old_android_build_instructions.md View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A + docs/old_cast_build_instructions.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + docs/old_chromeos_build_instructions.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + docs/old_chromoting_build_instructions.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + docs/old_ios_build_instructions.md View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A + docs/old_linux_build_instructions.md View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + docs/old_mac_build_instructions.md View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A + docs/old_windows_build_instructions.md View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M docs/windows_build_instructions.md View 1 2 3 3 chunks +150 lines, -44 lines 0 comments Download

Messages

Total messages: 31 (17 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526563003/60001
4 years ago (2016-11-30 00:51:27 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-11-30 00:51:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526563003/60001
4 years ago (2016-11-30 00:53:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-30 02:56:05 UTC) #12
Mike Lawther (Google)
Thanks for doing this Dirk! LGTM
4 years ago (2016-11-30 04:26:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2526563003/60001
4 years ago (2016-11-30 06:17:36 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-30 07:48:32 UTC) #22
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/0ae7cad40abf0a6ec7e9ebe8929c81ab979d64e4 Cr-Commit-Position: refs/heads/master@{#435138}
4 years ago (2016-11-30 07:53:47 UTC) #24
Nico
https://codereview.chromium.org/2526563003/diff/60001/docs/mac_build_instructions.md File docs/mac_build_instructions.md (right): https://codereview.chromium.org/2526563003/diff/60001/docs/mac_build_instructions.md#newcode119 docs/mac_build_instructions.md:119: $ ninja -C out/Default unit_tests --gtest_filter="PushClientTest.*" this should be ...
4 years ago (2016-11-30 18:47:08 UTC) #26
Dirk Pranke
On 2016/11/30 18:47:08, Nico wrote: > https://codereview.chromium.org/2526563003/diff/60001/docs/mac_build_instructions.md > File docs/mac_build_instructions.md (right): > > https://codereview.chromium.org/2526563003/diff/60001/docs/mac_build_instructions.md#newcode119 > ...
4 years ago (2016-12-01 01:56:33 UTC) #27
Nico
Do we have new cast build instructions anywhere? Googling for "cast build instructions" finds https://www.chromium.org/developers/how-tos/build-instructions-cast ...
3 years, 9 months ago (2017-03-03 22:53:40 UTC) #28
Dirk Pranke
On 2017/03/03 22:53:40, Nico wrote: > Do we have new cast build instructions anywhere? Googling ...
3 years, 9 months ago (2017-03-03 23:02:40 UTC) #29
Nico
On Fri, Mar 3, 2017 at 6:02 PM, <dpranke@chromium.org> wrote: > On 2017/03/03 22:53:40, Nico ...
3 years, 9 months ago (2017-03-21 19:04:45 UTC) #30
Dirk Pranke
3 years, 9 months ago (2017-03-21 22:02:15 UTC) #31
Message was sent while issue was closed.
Argh. I thought I had actually both posted a CL for this and landed it a
week or two ago, but I guess I failed completely to even upload it, so here:

https://codereview.chromium.org/2764013006/

:)

-- Dirk

On Tue, Mar 21, 2017 at 12:04 PM, Nico Weber <thakis@chromium.org> wrote:

> On Fri, Mar 3, 2017 at 6:02 PM, <dpranke@chromium.org> wrote:
>
>> On 2017/03/03 22:53:40, Nico wrote:
>> > Do we have new cast build instructions anywhere? Googling for "cast
>> build
>> > instructions" finds
>> > https://www.chromium.org/developers/how-tos/build-instructions-cast
>> and the
>> link
>> > there is now dead after this CL. But I don't see anything else I could
>> update
>> > the link to.
>>
>> Ah, maybe I forgot to add a new one. Will fix ASAP.
>>
>
> This is still a dead link.
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698