Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 2526563002: Add a target to run the SyzyAsan RTL unittests in 4G (Closed)

Created:
4 years, 1 month ago by Sébastien Marchand
Modified:
4 years ago
Reviewers:
chrisha
CC:
syzygy-changes_googlegroups.com
Target Ref:
refs/heads/master
Project:
syzygy
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Comments. #

Patch Set 3 : Add test #

Patch Set 4 : Disable the wild access test in 4G. #

Total comments: 4

Patch Set 5 : Rebase #

Patch Set 6 : Address nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -101 lines) Patch
M syzygy/agent/asan/asan.gyp View 5 chunks +23 lines, -6 lines 0 comments Download
D syzygy/agent/asan/dummy_shadow.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M syzygy/agent/asan/rtl_unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M syzygy/agent/asan/runtime.cc View 1 2 3 4 5 1 chunk +9 lines, -26 lines 0 comments Download
M syzygy/agent/asan/shadow.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M syzygy/agent/asan/shadow.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
D syzygy/agent/asan/static_shadow.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M syzygy/unittests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sébastien Marchand
PTAL.
4 years, 1 month ago (2016-11-22 23:19:54 UTC) #2
chrisha
lgtm with nits https://codereview.chromium.org/2526563002/diff/60001/syzygy/agent/asan/rtl_unittest.cc File syzygy/agent/asan/rtl_unittest.cc (right): https://codereview.chromium.org/2526563002/diff/60001/syzygy/agent/asan/rtl_unittest.cc#newcode274 syzygy/agent/asan/rtl_unittest.cc:274: TEST_ONLY_SUPPORTS_2G() ; https://codereview.chromium.org/2526563002/diff/60001/syzygy/agent/asan/runtime.cc File syzygy/agent/asan/runtime.cc (right): ...
4 years ago (2016-11-23 15:19:27 UTC) #3
Sébastien Marchand
Thanks, committing. https://codereview.chromium.org/2526563002/diff/60001/syzygy/agent/asan/rtl_unittest.cc File syzygy/agent/asan/rtl_unittest.cc (right): https://codereview.chromium.org/2526563002/diff/60001/syzygy/agent/asan/rtl_unittest.cc#newcode274 syzygy/agent/asan/rtl_unittest.cc:274: TEST_ONLY_SUPPORTS_2G() On 2016/11/23 15:19:27, chrisha (slow) wrote: ...
4 years ago (2016-11-23 15:28:04 UTC) #4
Sébastien Marchand
4 years ago (2016-11-23 15:28:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
7beea1aaaa61805991470b9d866d8fe52eb4c11d.

Powered by Google App Engine
This is Rietveld 408576698